Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp619301pxf; Wed, 31 Mar 2021 11:33:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLVHOg4H2BbARDMIk+slCVhcCkdCb9sNc0dGki6bSYzvRBCBvNxJ0OHDVhksYZ4likhAX4 X-Received: by 2002:a17:906:cb87:: with SMTP id mf7mr4963028ejb.81.1617215601504; Wed, 31 Mar 2021 11:33:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617215601; cv=none; d=google.com; s=arc-20160816; b=KLUywrzJ/s81Xc4U4rBLGoACyM8Mx0KxQrf/ObssRxcR2epYjbc9UYas/TZScbq3El 88NjyyvvJnN5qDf3bvQMDW1hLGQ0rjppQuUSzbi0fe6K4FHg0DUXhDIoTOt1/i9HxT+S xPwy0eoTpAy1wFKQMSbVIa5b2tBs5Zo9roxNViRxnT6k5a5AlYKYwjxSqk0inKjtFIhG uMU4XxtGzPu3DgEJ0VjqF1CImYlpGy8BwcrzI5sMGuinojxr2/W0UTkzAPg55rE+iik0 8zKYnvc2wmWcfMAtQJvQ3MxLjicO8lZqGxJ2HSLL4ZEm8/NXDAfp8zi+ZjbdEBBaft1t xrPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=lB7PZNCjA/mEfwgh0k3saX1FuNKie3qjCDZwP7jufcA=; b=qZIS/uAUWExT55KjnPNZswH+0IuIDQTR66DiMX2aa7a7LLgIiXprZgYgSifongWKm5 603OybB+gG48CGUlXaA+lOA78XMnlLwSkYJtHqFdbq//A6njVLLsc1P+AhbpoMoyZc52 aaX8VXKUwCLEaIy0NBasZF3oVfpI36cCI14XlxaZI5nwwASgcbfz+oU4rUf905I5/33c L4R+eUCMarLyJbSKU/BFsteQO3Q0KqiiK2y+vl1V1PLYdo3v0DrlxhmxEDrbHjgoWhs2 ZLv3FQWuv4IAfSYpeaQwHj3UfNfJT9SDfFoBgfKQSn6eQveWCnDkFTQMu30yfPDOzxJl npxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k22si2581398edv.400.2021.03.31.11.32.58; Wed, 31 Mar 2021 11:33:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235049AbhCaS34 (ORCPT + 99 others); Wed, 31 Mar 2021 14:29:56 -0400 Received: from mail.netfilter.org ([217.70.188.207]:48502 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234933AbhCaS3n (ORCPT ); Wed, 31 Mar 2021 14:29:43 -0400 Received: from us.es (unknown [90.77.255.23]) by mail.netfilter.org (Postfix) with ESMTPSA id 8DFD763E34; Wed, 31 Mar 2021 20:29:26 +0200 (CEST) Date: Wed, 31 Mar 2021 20:29:38 +0200 From: Pablo Neira Ayuso To: Colin King Cc: Jozsef Kadlecsik , Florian Westphal , "David S . Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] netfilter: nf_log_bridge: Fix missing assignment of ret on a call to nf_log_register Message-ID: <20210331182938.GA28208@salvia> References: <20210331142606.1422498-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210331142606.1422498-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 31, 2021 at 03:26:06PM +0100, Colin King wrote: > From: Colin Ian King > > Currently the call to nf_log_register is returning an error code that > is not being assigned to ret and yet ret is being checked. Fix this by > adding in the missing assignment. Applied, thanks.