Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp686940pxf; Wed, 31 Mar 2021 13:28:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgxOfvuHLjUs0HWKCUd1ZNUlDZR/7xlii9O5+nqe5MQAfxUyF4xpdPk31FAxZ0mS8YUCi9 X-Received: by 2002:a05:6402:278d:: with SMTP id b13mr5910677ede.34.1617222527506; Wed, 31 Mar 2021 13:28:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617222527; cv=none; d=google.com; s=arc-20160816; b=s8Ax5yhtKf///zyoCnxyHfLnIGUZxbXie2cSh+gyIhH5+56BL2x45103jGoFNmMeTb TXIWrNPfKqxMVE+5JNw+0ng6a0rP4YrOq01oVnf45ZZwmfugrM1QQv2dqOgDcsArqPMq qRGHJ6vGQMXPT1FCZWVx6slE97DKiuxqyWT43/TmrXsZj8BmQ9KAWo9WaZbzQIZvceow k2wXbkL1ddWqdu62mDvRKMuMocYiwh+2HCW/0/sy/XyHDQ13nfolNs+ZWynsLiof7GOG r5fz8ufCBUMTGNRL1wdP+vVHqzFMtHnwsLRUU/l9Ww8PviqFz+8dOo6IUalH3GMan+h2 QjOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature:dkim-filter; bh=V69OvbPP4NOdAIt0hpaxumI8PQ/bvcYp0rVSuSOspz0=; b=dQGwWbBTDiqm7ZQ50hJbgc4CtjU8Xoj4FfoMAmLT+N745pPqr1yMJQRBsLNuz3gEPx 4A9FBPuHte3MZuGyqRy/YEAT+hDv+AE7R9/TvfOrq8rAk3EAUqmeDdxyE0HGvrCTRp5v fjvYME9YPsQACw/kpNocuYjXZz5HJ8eWbfK8Lio4RQvbFpAsL2PhYtz4x1foq030WSCy xDMhgQBy/hptYtIPGJmf4zjzq44dX35zUfoOL0RhU21Jx3hHi05u7tvACp8C5u7yw/AC 3tLrSkMSuiD2a0B8KMAp5jhzhP10fX1XQbWbA83e/xMG0+xFvV6SeeoPX4PTXp6gbuW9 8Ncw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=qndR9uk9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca25si2634456edb.204.2021.03.31.13.28.19; Wed, 31 Mar 2021 13:28:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=qndR9uk9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236442AbhCaUY3 (ORCPT + 99 others); Wed, 31 Mar 2021 16:24:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236441AbhCaUYT (ORCPT ); Wed, 31 Mar 2021 16:24:19 -0400 Received: from ms.lwn.net (ms.lwn.net [IPv6:2600:3c01:e000:3a1::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7D60C061574; Wed, 31 Mar 2021 13:24:18 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:281:8300:104d::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id A81FF867; Wed, 31 Mar 2021 20:24:18 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net A81FF867 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1617222258; bh=V69OvbPP4NOdAIt0hpaxumI8PQ/bvcYp0rVSuSOspz0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=qndR9uk9iHQlt4ULDyGVHLbKrxpIuqPacZyF11P/wtVbXiu/l6euEHfwMcgURxULQ Kt737M9aauHClqbkb0sRv0KaMXIIITE3Su/VwnYXDbNnpo3xpIwsppxlzZQAJrHfip XrHXlquCz/CDpwuZsDBzm090DIyiV/5mLNZIN22g0mUDLDcxg092Fu68aYuYhRhkZW FkgO3QRuCdTJOqcTVfPGAbSGwrzer9XTOo9+20f/BrRT9N3mo14dO2udUSvbs5iuvY lUvrRBG0cnYYVDn1wkb4zYXHMvgC48ziIOI+7Dozf+AssEorYwmDQH8D6EIDl3Tg75 FPCzkkkzoM55w== From: Jonathan Corbet To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Randy Dunlap , Al Viro , linux-doc@vger.kernel.org Subject: Re: [PATCH 1/2] fs/namespace: corrent/improve kernel-doc notation In-Reply-To: <20210318025227.4162-1-rdunlap@infradead.org> References: <20210318025227.4162-1-rdunlap@infradead.org> Date: Wed, 31 Mar 2021 14:24:18 -0600 Message-ID: <87r1jvjclp.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Randy Dunlap writes: > Fix kernel-doc warnings in fs/namespace.c: > > ./fs/namespace.c:1379: warning: Function parameter or member 'm' not described in 'may_umount_tree' > ./fs/namespace.c:1379: warning: Excess function parameter 'mnt' description in 'may_umount_tree' > ./fs/namespace.c:1950: warning: Function parameter or member 'path' not described in 'clone_private_mount' > > Also convert path_is_mountpoint() comments to kernel-doc. > > Signed-off-by: Randy Dunlap > Cc: Al Viro > Cc: Jonathan Corbet > Cc: linux-doc@vger.kernel.org > --- > Jon, Al has OK-ed you to merge this patch (and the next one, please). > > fs/namespace.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) An actual acked-by would have been nice, oh well. Meanwhile, I've applied them with fixes to the typos in both changelogs :) Thanks, jon