Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: yuDK7XMrYUnuqzfXDyfjZ6NR2MC0JT3r0H1har6s3ITfhE2a90C2j78K72Mmc8frvcSXLHcmhO
 9r7jTSeXnSKg==
IronPort-SDR: FHmohomgvnJDA9mtHdrwa91RA3IpF0X1FypVWyctU3H6H+E3UuG78d9O8DmSdXFTPtDTgPQ08j
 XPo/BS2D1iyA==
Subject: Re: [PATCH v2 05/24] x86/resctrl: Label the resources with their
 configuration type
To:     James Morse <james.morse@arm.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        shameerali.kolothum.thodi@huawei.com,
        Jamie Iles <jamie@nuviainc.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>
References: <20210312175849.8327-1-james.morse@arm.com>
 <20210312175849.8327-6-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
Message-ID: <036004f2-828d-51f8-967d-a0b0625dd8d0@intel.com>
Date:   Wed, 31 Mar 2021 14:37:56 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210312175849.8327-6-james.morse@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi James,

On 3/12/2021 9:58 AM, James Morse wrote:

> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index 8a9da490134b..57484d2f6214 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -361,12 +361,14 @@ struct rdt_parse_data {
>   
>   /**
>    * struct rdt_hw_resource - hw attributes of a resctrl resource
> + * @conf_type:		The type that should be used when configuring. temporary

This is annotated with "temporary" but still remains after entire series 
is applied.

Reinette