Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp10389pxf; Wed, 31 Mar 2021 15:02:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFx8sAYlgHpG2Zly2/UYCGiCcF/syeb1C1lBhKfnFQCiFQGE1RUgTuc5kruwbTjRx5UxcM X-Received: by 2002:aa7:da06:: with SMTP id r6mr6469284eds.86.1617228156728; Wed, 31 Mar 2021 15:02:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617228156; cv=none; d=google.com; s=arc-20160816; b=g78cJkjU15zyFVdEnCA39iZnSXPHk/535MTtkqNEAx4XsaN2DIvIigwxGA7yKKf6I2 zYKOs0HzwYD8vyHcrr1TIhOGQSPdp4t+iQeuQ3EWxuJu9MgYENOvXwnmK7sEKkexYBb9 wWZq+TmEPauq56ku+mPPjHN9jjhUfKusXYvn4s8eSVOGiFBCCN0cn12urRSQIC92U2k9 fuASd5UAXUrvVoSD12Um1Dq7Fu5Clb5lmXO7y00FPPTKOdRiaObL9jBqKKRDCLC5TCQs OVzsbD99IG2R0xIWmjsGPzxOZ3DV47OoxttR95CBVkJJHuhWtLHAp73UQ4PxGj8PzMR0 lnBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=aO1in8qj4aFXp9PXGkprQ2mvYXQRASBzWKSRAeuCQy8=; b=oTzhlCxxiSuZhgfYpDyJE8uaJTMZQwsk5/XizXQsSDHUhPoq8d/kPCYNOyRKhmhRn8 WhBclgaghO96OmzdhWh1JGV5xtgJSAJsLc8/AnOyGb7vuiBmULQgs3EDYcQTbaNHEfiw ka74PY9vmriaxiJJ0JT75CKe/i84h/xd6MxmQ3gU7BX9sJyj/PSCSw6oSMoeLf3KgoF8 Tt5hBpzDwEqniDc5t2UhVSs+a6TqWHVe8kgG+QLwCxhbkK1gulqBN73mjqlRfLamxjLa vQKxTiZr8SYC1TGu1nomwRIYNKxVTgRPnfF2KHJbniKnMOwGETDY83D/Ai2ctxFRpkAb HUEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w16si2881571edd.471.2021.03.31.15.02.13; Wed, 31 Mar 2021 15:02:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232601AbhCaWBB (ORCPT + 99 others); Wed, 31 Mar 2021 18:01:01 -0400 Received: from mga11.intel.com ([192.55.52.93]:62506 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231676AbhCaWAf (ORCPT ); Wed, 31 Mar 2021 18:00:35 -0400 IronPort-SDR: A07JH/gQpo9UZi/hPkczR/r6R1Iyipm+1Is21weluBZ88C2lpQeQBA9dP1joPmQV+uLcxCnmwd elwLc8S3Aobw== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="188840334" X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="188840334" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 15:00:35 -0700 IronPort-SDR: wrdoTYr/42ISLP0b4O6OBy0ToBLByXBnlURGfNgKPd6KE/jnwCxCP8U18dqg74PnMjXpp6Zqtw VibEMx8FadLA== X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="418873309" Received: from algolden-mobl1.amr.corp.intel.com (HELO [10.209.172.7]) ([10.209.172.7]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 15:00:34 -0700 Subject: Re: [PATCH v4 1/1] x86/tdx: Handle MWAIT, MONITOR and WBINVD To: Sean Christopherson , Kuppuswamy Sathyanarayanan Cc: Peter Zijlstra , Andy Lutomirski , Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Dan Williams , Raj Ashok , linux-kernel@vger.kernel.org References: <2FE32855-EA5D-44E4-AACC-25E9B1476547@amacapital.net> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <5d961c25-3dee-4a5d-4bba-a97d157a5a49@intel.com> Date: Wed, 31 Mar 2021 15:00:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/31/21 2:53 PM, Sean Christopherson wrote: > On Wed, Mar 31, 2021, Kuppuswamy Sathyanarayanan wrote: >> Changes since v3: >> * WARN user if SEAM does not disable MONITOR/MWAIT instruction. > Why bother? There are a whole pile of features that are dictated by the TDX > module spec. MONITOR/MWAIT is about as uninteresting as it gets, e.g. absolute > worst case scenario is the guest kernel crashes, whereas a lot of spec violations > would compromise the security of the guest. So, what should we do? In the #VE handler: switch (exit_reason) { case SOMETHING_WE_HANDLE: blah(); break; ... default: pr_err("unhadled #VE, exit reason: %d\n", exit_reason); BUG_ON(1); } ? Is this the *ONLY* one of these, or are we going to have another twenty? If this is the only one, we might as well give a nice string error message. If there are twenty more, let's just dump the exit reason, BUG() and move on with our lives.