Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp21473pxf; Wed, 31 Mar 2021 15:22:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHG61/k023zXIyv8OqHAT10Dg7R9foueeqAy/+I9Q0FqiU9P5hrSHAtNdfQyuub5cR5Nu0 X-Received: by 2002:a17:906:b80c:: with SMTP id dv12mr6027792ejb.110.1617229323103; Wed, 31 Mar 2021 15:22:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617229323; cv=none; d=google.com; s=arc-20160816; b=aS+XF74pnb7kuGPiumrsjSr+CgD+Ys9o7qGMRassxIx9sC5LMaXIJoPtMHktguaOr8 cYUk1yplpGzV3b8eapap0vnNSIzfih2//LWlkm5WVTnoAPqX3bCDuRbwuuvllUmnwm79 MLVAEaMi4IuVFEukm7o453xc+BybPDb4Xr9tnRU47L5xwPsyuIoOoMiVlfwx09Ntr1IK e/Z737FQTjoL8h5WmUEBQ2dl7rAA6PPE+xzN03sSyx0FSs8MuoQ4ow/+vOAa3G5lKmLu z06lAoR4wEYa1rX1622wHcpAwOVnWk8c8MRGWK8q4IHeVs9ja2fsOC/s+EiqLee3WEo0 BIQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=9zdDutR9EhLIzVyatsKZsF7rTIWcg8JpWsSEWn2Lhnw=; b=gp8bV0orYAsw319faI3pKIS4cT3KewsAneiAqV6g8V8/XLX4c0DDC5dzBI/TCHIRXa CisCwJAtb7wFJ4dgLzqpu8w9Pz2qlQSYkjrWfTyGkgi7Mjm/68CYn5z8mG1wWzAOhGZQ jxibbf73duXshjeKXjfAaK+AOOpXHw7ACRVQH1LNOqcA0inBWMaNF3ykZ8wwuRMz18pY wrP6XFbOM99A7+unWMtZnB9vf087ZkUU3FQ7vyc6/sHe9mD/h77irE7rJpjd7wQeMsYr zMCqOUeJ7usOoBP6Oj7eqe64fhU3JJSRgFNmHoQw7aJ1JMJlfJnehUgfaPYkNcm2t06x qTrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ggfSqsxq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qt26si2736149ejb.216.2021.03.31.15.21.40; Wed, 31 Mar 2021 15:22:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ggfSqsxq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232690AbhCaWUp (ORCPT + 99 others); Wed, 31 Mar 2021 18:20:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:50130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbhCaWUP (ORCPT ); Wed, 31 Mar 2021 18:20:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id E041361078; Wed, 31 Mar 2021 22:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617229214; bh=emkVMfPNBs6VfL684ehH4JMVFlgqaT3Etox40Szo5fc=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=ggfSqsxqY3UdBekUS7UQ+WrTQDNqajcwkk6yfCx+rmWlEWOtOj34DM5BTy7gHe7gd 8PEyr+YhqSfNIhu/2ZfSHXaE0npMKXqHZ8ucfLlz8Obam6EmcSb9Sn++SzowpN9/Ou osec4i+x86CM/UNIz4GvbmQwoVDBkDbU3Rwfs4TM5Ecdxb+UJNJQ4wDBhBvjB1+NnA s+cjOmAq7PPMGmszMG2kDLcUQfyLyUbzU4AL0nAxAhf13hS9who4+vmJ345iBdi+VF QYYmdfNJc28KXZRNHOj7xFZJsj2hqIdKbK9mr+cghZn5j4ushOaJ6tS/acFRVOHg2v iagDefN6srTHw== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id D4A6D608FA; Wed, 31 Mar 2021 22:20:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v2 1/1] xdp: fix xdp_return_frame() kernel BUG throw for page_pool memory model From: patchwork-bot+netdevbpf@kernel.org Message-Id: <161722921486.2890.11294519050752062288.git-patchwork-notify@kernel.org> Date: Wed, 31 Mar 2021 22:20:14 +0000 References: <20210331132503.15926-1-boon.leong.ong@intel.com> In-Reply-To: <20210331132503.15926-1-boon.leong.ong@intel.com> To: Ong Boon Leong Cc: ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, kuba@kernel.org, hawk@kernel.org, john.fastabend@gmail.com, makita.toshiaki@lab.ntt.co.jp, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 31 Mar 2021 21:25:03 +0800 you wrote: > xdp_return_frame() may be called outside of NAPI context to return > xdpf back to page_pool. xdp_return_frame() calls __xdp_return() with > napi_direct = false. For page_pool memory model, __xdp_return() calls > xdp_return_frame_no_direct() unconditionally and below false negative > kernel BUG throw happened under preempt-rt build: > > [ 430.450355] BUG: using smp_processor_id() in preemptible [00000000] code: modprobe/3884 > [ 430.451678] caller is __xdp_return+0x1ff/0x2e0 > [ 430.452111] CPU: 0 PID: 3884 Comm: modprobe Tainted: G U E 5.12.0-rc2+ #45 > > [...] Here is the summary with links: - [net,v2,1/1] xdp: fix xdp_return_frame() kernel BUG throw for page_pool memory model https://git.kernel.org/netdev/net/c/622d13694b5f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html