Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: J+amwlH/HUZNX2Mb1pdkbMJ7pQU1UN0Aed8+3vZrnt6gS0cmA6r9JqI+d1rzCT8wdWVNCfb8nT
 jyi1HlYPGKdg==
IronPort-SDR: q84Mbr6GTdcqrEw1OcK8lUatWI/ngVamlhNwOzmHE5VQlQZnfhRDRwcd6YNeZKNJF1V/wnQcuL
 D5mtcElaznLg==
Date:   Wed, 31 Mar 2021 18:15:40 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Dan Williams <dan.j.williams@intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
        linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH V5 08/10] x86/entry: Preserve PKRS MSR across exceptions
Message-ID: <20210401011540.GG3014244@iweiny-DESK2.sc.intel.com>
References: <20210331191405.341999-1-ira.weiny@intel.com>
 <20210331191405.341999-9-ira.weiny@intel.com>
 <dcd6a103-5220-d624-0655-b9c7146f9de5@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dcd6a103-5220-d624-0655-b9c7146f9de5@intel.com>
User-Agent: Mutt/1.11.1 (2018-12-01)
Precedence: bulk

On Wed, Mar 31, 2021 at 12:31:56PM -0700, Dave Hansen wrote:
> On 3/31/21 12:14 PM, ira.weiny@intel.com wrote:
> > + * To protect against exceptions having access to this memory we save the
> > + * current running value and sets the PKRS value to be used during the
> > + * exception.
> 
> This series seems to have grown some "we's".

I suppose it has...

> 
> The preexisting pkey code was not innocent in this regard, either.  But,
> please fix this up across the series in the next submission.  Literally
> removing "we" from this sentence doesn't change the meaning at all.

Sure I can audit the series for this...  Waiting a day for other comments.

Thanks,
Ira