Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp138454pxf; Wed, 31 Mar 2021 19:21:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJZALAEiTdkJxDPO5o34uD6gGvwskHPib+zLFWqEokd4G0xnrTNTVIcKZvorJr8Bnw3Big X-Received: by 2002:a05:6402:440d:: with SMTP id y13mr7385844eda.316.1617243688125; Wed, 31 Mar 2021 19:21:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617243688; cv=none; d=google.com; s=arc-20160816; b=nCjbFlWLl1/AT3hyARwqJhXdE12Z54LL2fI1sN/fYaUzI5bQ4tASHiPgNUYI52YfIZ 6iKcGOO5pKg/mZ1IMuubsEwHz/Z7r1PQgDUo3AwUYYAAHbO1NG9YB5dIjcMXc5zywDHC r7w9Y2HwWlbS62ZigbFNeudzbtcPqLKDfhKMa9V7zO296nS6Vm7RVNG8fIv0e8I47jlu 0PRd3E8jqPooFv/kg1ICDMC0i/MK9BKjz7W056tDSh8cCiwSA/F6mfNIVigc4JKuAOFc DGXJp3m2hEIfUiXhNPGjD9c5YUCyC3lIgkacTc1uuySVsUW41zpcDAmB7LaqoZ+kjm9R wTmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=AOpy6bs+5K7yYGnqFC2awZt1k7MqHZPA2iPJ82FX6gc=; b=s2iVLX/RFBdxeGJmiRvEU24COmz6HLANGTMJie/PBszQVmAaWwXzVgMpyhqNH235sT J50Ke1XiyQzFXje38wXRHuc3ww4mvBFvb1tNQlR7+m4acdZkr2kVivFV6vc/dopgBflo 7xZn/J4eqgKzYEgXqp9+XSp0D2t39/v6hmZ6VxXFlJc3kbo30yNTwzX6trJXqV3bkMg6 hgc20hrlQkHq9QZU8R/KeWHA1IobpQWVw9yuevlQ+OTFGd13GK1jDx+9s1GOvQD2t0cQ JszSSxA1qSWodB3QJoXJMOi/rQGXefby5r8EB3Xn9dgaTQNxjwLC9oJ/3Y3sGXtjgMWg +TNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qu25si2993191ejb.665.2021.03.31.19.21.05; Wed, 31 Mar 2021 19:21:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232565AbhDACTt (ORCPT + 99 others); Wed, 31 Mar 2021 22:19:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232672AbhDACTP (ORCPT ); Wed, 31 Mar 2021 22:19:15 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA267C061574; Wed, 31 Mar 2021 19:19:15 -0700 (PDT) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94 #2 (Red Hat Linux)) id 1lRmvQ-001X5H-Kb; Thu, 01 Apr 2021 02:19:12 +0000 Date: Thu, 1 Apr 2021 02:19:12 +0000 From: Al Viro To: Jonathan Corbet Cc: Randy Dunlap , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 1/2] fs/namespace: corrent/improve kernel-doc notation Message-ID: References: <20210318025227.4162-1-rdunlap@infradead.org> <87r1jvjclp.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r1jvjclp.fsf@meer.lwn.net> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 31, 2021 at 02:24:18PM -0600, Jonathan Corbet wrote: > Randy Dunlap writes: > > > Fix kernel-doc warnings in fs/namespace.c: > > > > ./fs/namespace.c:1379: warning: Function parameter or member 'm' not described in 'may_umount_tree' > > ./fs/namespace.c:1379: warning: Excess function parameter 'mnt' description in 'may_umount_tree' > > ./fs/namespace.c:1950: warning: Function parameter or member 'path' not described in 'clone_private_mount' > > > > Also convert path_is_mountpoint() comments to kernel-doc. > > > > Signed-off-by: Randy Dunlap > > Cc: Al Viro > > Cc: Jonathan Corbet > > Cc: linux-doc@vger.kernel.org > > --- > > Jon, Al has OK-ed you to merge this patch (and the next one, please). > > > > fs/namespace.c | 14 ++++++++------ > > 1 file changed, 8 insertions(+), 6 deletions(-) > > An actual acked-by would have been nice, oh well. Meanwhile, I've > applied them with fixes to the typos in both changelogs :) Generally speaking, I'm only glad to leave handling kernel-doc patches to somebody else, especially when they are that trivial ;-) Anyway, Acked-by: Al Viro