Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] i2c: gpio: use DEFINE_SPINLOCK() for spinlock
To:     Russell King <linux@armlinux.org.uk>
CC:     <heying24@huawei.com>, <yuehaibing@huawei.com>,
        <weiyongjun1@huawei.com>, <johnny.chenyi@huawei.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
References: <20210327095228.105123-1-chenlifu@huawei.com>
From:   chenlifu <chenlifu@huawei.com>
Message-ID: <fec9295e-c5d6-13ee-23f5-13b593d2fd2e@huawei.com>
Date:   Thu, 1 Apr 2021 11:38:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210327095228.105123-1-chenlifu@huawei.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Kindly pinging ...

Best Regards,
Chen Lifu

?? 2021/3/27 17:52, Chen Lifu д??:
> From: Lifu Chen <chenlifu@huawei.com>
> 
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Lifu Chen <chenlifu@huawei.com>
> ---
>   arch/arm/mach-sa1100/simpad.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-sa1100/simpad.c b/arch/arm/mach-sa1100/simpad.c
> index c7fb9a73e4c5..c183432880d3 100644
> --- a/arch/arm/mach-sa1100/simpad.c
> +++ b/arch/arm/mach-sa1100/simpad.c
> @@ -45,7 +45,7 @@
>    */
>   
>   static long cs3_shadow;
> -static spinlock_t cs3_lock;
> +static DEFINE_SPINLOCK(cs3_lock);
>   static struct gpio_chip cs3_gpio;
>   
>   long simpad_get_cs3_ro(void)
> @@ -379,8 +379,6 @@ static int __init simpad_init(void)
>   {
>   	int ret;
>   
> -	spin_lock_init(&cs3_lock);
> -
>   	cs3_gpio.label = "simpad_cs3";
>   	cs3_gpio.base = SIMPAD_CS3_GPIO_BASE;
>   	cs3_gpio.ngpio = 24;
> 
> .
>