Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp222505pxf; Wed, 31 Mar 2021 22:31:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4tEW82Pbd94N4uts/3oZPW6l04GqGwMB2CQpXeIyquQ9cWhsRf6O474egYof1KCqy+6S/ X-Received: by 2002:a17:907:62a7:: with SMTP id nd39mr7369339ejc.510.1617255083550; Wed, 31 Mar 2021 22:31:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617255083; cv=none; d=google.com; s=arc-20160816; b=q3C+ElBWs1vLx3hYcMRUer/caC9L1WypuIO8qyFkmQ0Wmbq057+ZBfIgsfAosoM0c0 oiK3a8z3O/5fhb/P9N7uaA6CXktLKFvXUIcx6iOlMSMd+/qRFwuBBWHC4jdbAaUbOcX3 qxjJ8gBoJ8xWiiMypk10+QnMhcmCePBSK9A5Q5NEshqMNnj7lclR3K4j70Nu4PAhZMwt y6U4M1Wcl4tZno8X5i9QJgP3haKyE0jbLArlO+DWe2SeeIwQqM+0MYkZ4dzMlF9h4QgN ysVMtg9KkrAVsKZcdm0qcCOl4EPHPgzu153nMc7V5I+CDXsmLyaDjGBw0c5AbVP2fwCJ Wy4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=pfCF7tRn02E38ePtRNFpGi3tB12XW7uGCYeirKTFJ0Y=; b=I7YOwNfj0IVDAzf3yVxA1CoZlC658fo7k8Fe7rk+trPx+1CojsX7jyct4a958B2m1Y bxNEUvOl0gOO/wC0dYkHeKwu+0K3W/u5SIgUgMI9Le1pDyiMSas+vbYBXWw7uSsJ0FiN KTFdoR0S/O36zWGXhnuV8bM1bMpsAfFvGxsmOYDuJPKAJ2Qy+gzwMQ6BlkI1SwOiKsmV o79CuCzurKJDwLBAHzddGIZCVe7eJ+amrDQzngWZKynpwcWSl+KIS+YljjgWHuZcfZmQ kn60VSJh444pSGAC9+RkufktkIpdHww8PQZ68FVSiyQFg4w3YsZqOFW2pX83BHzW6u+N ovCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sfwJqf3F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s20si3748781edd.177.2021.03.31.22.31.01; Wed, 31 Mar 2021 22:31:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sfwJqf3F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232672AbhDAF3y (ORCPT + 99 others); Thu, 1 Apr 2021 01:29:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:37966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbhDAF3f (ORCPT ); Thu, 1 Apr 2021 01:29:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D8EE961055; Thu, 1 Apr 2021 05:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617254975; bh=4PD+/hmJOe6KDN5FqP2OiD2BFsgSpXT4q7TiOZRXfiI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sfwJqf3FAxfq4ODvNsQxu+vILMnIHP3toOj6nBHslLccpdJVtR9P9v/5WC+m+8uun LhHLgETE4HuNBlX0eNAjELY9+1O0d89j90QaOgORB4eeyBLJIqmuCy3FBw26dqKrgZ AB4ct5JxC0q5qkIJpwneUS9d/SU1fiJsI3VgMi+mpVEYix9G8Sb7KtgA6W9/CpU+Fa gs/UOEL+K4q+L2Xssi5MBeq+8FZIKyOAj7xqFB1hYdAFy2ExXTZNhAPnVXaOn29WHI JlP66dsMuEIz2LyjDq2zeQ9gpwRpMQIxCTMkGuyYQ1eH+4YRWOoztk45A+JuIyQHoC qpHSz8Tda29rA== Date: Thu, 1 Apr 2021 10:59:29 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] arm: dts: owl-s500-roseapplepi: Add ATC2603C PMIC Message-ID: <20210401052929.GC14052@work> References: <2e0a2931ae3757f016948e7c78e8e54afa325ae0.1615538629.git.cristian.ciocaltea@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e0a2931ae3757f016948e7c78e8e54afa325ae0.1615538629.git.cristian.ciocaltea@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 12, 2021 at 11:49:27AM +0200, Cristian Ciocaltea wrote: > Add device tree node for ATC2603C PMIC and remove the 'fixed-3.1V' > dummy regulator used for the uSD supply. > > Additionally, add 'SYSPWR' fixed regulator and provide cpu0 supply. > > Signed-off-by: Cristian Ciocaltea Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > Please note the patch depends on the ATC260x PMIC support which is queued > for merging in v5.13: > > https://lore.kernel.org/lkml/cover.1611653995.git.cristian.ciocaltea@gmail.com/ > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/log/?h=for-mfd-next&qt=range&q=a38fd8748464831584a19438cbb3082b5a2dab15..eac013a0b7041f5cfc8feedf429a767675350102 > > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 132 ++++++++++++++++++++- > 1 file changed, 126 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > index ff91561ca99c..b8c5db2344aa 100644 > --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts > +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > @@ -2,7 +2,7 @@ > /* > * Roseapple Pi > * > - * Copyright (C) 2020 Cristian Ciocaltea > + * Copyright (C) 2020-2021 Cristian Ciocaltea > */ > > /dts-v1/; > @@ -27,20 +27,140 @@ memory@0 { > reg = <0x0 0x80000000>; /* 2GB */ > }; > > - /* Fixed regulator used in the absence of PMIC */ > - sd_vcc: sd-vcc { > + syspwr: regulator-5v0 { > compatible = "regulator-fixed"; > - regulator-name = "fixed-3.1V"; > - regulator-min-microvolt = <3100000>; > - regulator-max-microvolt = <3100000>; > + regulator-name = "SYSPWR"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > regulator-always-on; > }; > }; > > +&cpu0 { > + cpu0-supply = <&vdd_cpu>; > +}; > + > &i2c0 { > status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&i2c0_pins>; > + > + atc260x: pmic@65 { > + compatible = "actions,atc2603c"; > + reg = <0x65>; > + interrupt-parent = <&sirq>; > + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>; > + > + reset-time-sec = <6>; > + > + regulators { > + compatible = "actions,atc2603c-regulator"; > + > + dcdc1-supply = <&syspwr>; > + dcdc2-supply = <&syspwr>; > + dcdc3-supply = <&syspwr>; > + ldo1-supply = <&syspwr>; > + ldo2-supply = <&syspwr>; > + ldo3-supply = <&syspwr>; > + ldo5-supply = <&syspwr>; > + ldo6-supply = <&syspwr>; > + ldo7-supply = <&syspwr>; > + ldo8-supply = <&syspwr>; > + ldo11-supply = <&syspwr>; > + ldo12-supply = <&syspwr>; > + switchldo1-supply = <&vcc>; > + > + vdd_cpu: dcdc1 { > + regulator-name = "VDD_CPU"; > + regulator-min-microvolt = <700000>; > + regulator-max-microvolt = <1400000>; > + regulator-always-on; > + }; > + > + vddq: dcdc2 { > + regulator-name = "VDDQ"; > + regulator-min-microvolt = <1300000>; > + regulator-max-microvolt = <2150000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + vcc: dcdc3 { > + regulator-name = "VCC"; > + regulator-min-microvolt = <2600000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vcc_3v3: ldo1 { > + regulator-name = "VCC_3V3"; > + regulator-min-microvolt = <2600000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + avcc: ldo2 { > + regulator-name = "AVCC"; > + regulator-min-microvolt = <2600000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vdd_1v8: ldo3 { > + regulator-name = "VDD_1V8"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <2000000>; > + regulator-always-on; > + }; > + > + vcc_3v1: ldo5 { > + regulator-name = "VCC_3V1"; > + regulator-min-microvolt = <2600000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + avdd: ldo6 { > + regulator-name = "AVDD"; > + regulator-min-microvolt = <700000>; > + regulator-max-microvolt = <1400000>; > + regulator-always-on; > + }; > + > + sens_1v8: ldo7 { > + regulator-name = "SENS_1V8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + ldo8: ldo8 { > + regulator-name = "LDO8"; > + regulator-min-microvolt = <2300000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + svcc: ldo11 { > + regulator-name = "SVCC"; > + regulator-min-microvolt = <2600000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + rtc_vdd: ldo12 { > + regulator-name = "RTC_VDD"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + }; > + > + sd_vcc: switchldo1 { > + regulator-name = "SD_VCC"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + }; > + }; > }; > > &i2c1 { > -- > 2.30.2 >