Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp239107pxf; Wed, 31 Mar 2021 23:07:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtwuoNVCXY6wfdH0V5uEuYvqSokCmcFEjqkZiTlGs+YxkdyfMhUmGZoxUi/ogd02aQ6+qe X-Received: by 2002:a05:6402:5252:: with SMTP id t18mr8206241edd.258.1617257227850; Wed, 31 Mar 2021 23:07:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617257227; cv=none; d=google.com; s=arc-20160816; b=EpAq0S//zKSjBAVsElf7DTmgl7wlGq0moGqAQOZQusfG6v0wMjS2bZBnHRgmRDIlR3 wXj98J3WN2SnNuAIt7sCIE2wm9xfpfR0JQMg4OJ/g5H0sphQnBjhwJbIEYp58giF0SE1 ohxMkp/B11SLPJOgDogDG6upQFAKnWVsIoDWPEqmYYrMpe9ZC/OIL58gRiTsXum2eLM0 1BA7Je3QRfuWfSIuTCkD9HXAFZCc7fkPN5STVjh93SVocAqx9m8Rod3eo/3TAl28ViR/ yJpl6gFcdQmVJUW2I2vWfp0SKt4udFw4nLeXxqQT0Xd5A+DEfSL2nnPjcm4RpptxaPBb 2w+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=ZiOEGyc7zmLl8TA08ti89/9YpleCO+psMmYdBO+HuJM=; b=EbziMgzNmLojfYzivNQGrcQvs9cCgWVSkAEKr9Jsbh22UhhgER4bYoBFUmK2u7rI/N 3q80vr3/XcIyhpOne46JMqALNrv7vGuRkN5oiJLqtHwjjqUYE6iCcNaPjvj5f4EoAHT4 BUDBUqzYM76Sswf8DL4c0UngzvFD3CeR/Xyh9+sZ8U5ZVoT5N042gOtZmI4U/APlJ8W0 jbiqwuFMRcugmjaOwFkT2B0urO8esCGimHjbE4kJ0xD6ZIQ5Z0+8z8xPMwpMh6LlfZfg Pg11ObzbhJV4jFVGZldg942TTH6cdPHoaDFPXqKR34lPRw+3z7nD8yWH2x1Rn53Hecgp wvlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j10si3738317ejs.618.2021.03.31.23.06.45; Wed, 31 Mar 2021 23:07:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233374AbhDAGCr (ORCPT + 99 others); Thu, 1 Apr 2021 02:02:47 -0400 Received: from mga04.intel.com ([192.55.52.120]:24122 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233589AbhDAGCS (ORCPT ); Thu, 1 Apr 2021 02:02:18 -0400 IronPort-SDR: UWmDSWNdsWUV+rcRMAK5bEsrFweQJpG3mtTOzoTiOWvzj330R7pQKAOAAz0wJjfQ2axZbSle96 Y35IJkTk0sKQ== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="189929995" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="189929995" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 23:02:14 -0700 IronPort-SDR: 3syucskN8LM8LtLBaJYl15+HJr2elqI3Irezo8nFFZK7qqndb3cAk7h8Sm6ZMiEAa1rK5s636C M8QXjV6XVGBA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="377569641" Received: from linux.intel.com ([10.54.29.200]) by orsmga003.jf.intel.com with ESMTP; 31 Mar 2021 23:02:09 -0700 Received: from glass.png.intel.com (glass.png.intel.com [10.158.65.59]) by linux.intel.com (Postfix) with ESMTP id 6387F5808ED; Wed, 31 Mar 2021 23:02:07 -0700 (PDT) From: Wong Vee Khee To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/1] net: stmmac: remove unnecessary pci_enable_msi() call Date: Thu, 1 Apr 2021 14:06:28 +0800 Message-Id: <20210401060628.27339-1-vee.khee.wong@linux.intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The commit d2a029bde37b ("stmmac: pci: add MSI support for Intel Quark X1000") introduced a pci_enable_msi() call in stmmac_pci.c. With the commit 58da0cfa6cf1 ("net: stmmac: create dwmac-intel.c to contain all Intel platform"), Intel Quark platform related codes have been moved to the newly created driver. Removing this unnecessary pci_enable_msi() call as there are no other devices that uses stmmac-pci and need MSI to be enabled. Signed-off-by: Wong Vee Khee --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c index 272cb47af9f2..95e0e4d6f74d 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c @@ -198,8 +198,6 @@ static int stmmac_pci_probe(struct pci_dev *pdev, if (ret) return ret; - pci_enable_msi(pdev); - memset(&res, 0, sizeof(res)); res.addr = pcim_iomap_table(pdev)[i]; res.wol_irq = pdev->irq; -- 2.25.1