Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp264830pxf; Thu, 1 Apr 2021 00:03:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjEF3LKuOlJWpuzLpcjhs0KVirZh2ii3k4cqmBJAIsqfxoOIVuD2zSKRruLMJBjhq9TNl+ X-Received: by 2002:a17:907:270d:: with SMTP id w13mr7746915ejk.340.1617260623036; Thu, 01 Apr 2021 00:03:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617260623; cv=none; d=google.com; s=arc-20160816; b=jCHGGySzxXOECQ3TXiqcEdIUe/9BJqNwB0p15K/lrzUEhK5qJVJnchNjR9qCQ2Ct2y b0MHxca7PugNogIDLucZRP6hHo6S9ASYcd0A09q2OFk1bfd9oYYq/S6POKGVqdOLkN2Z W/wgmczHF1cQq7h2FeO69Cf05Ky4B5CMJQBHdpYAp5iyaSR5IfqCL0SYBBzc1iZ8TA4r 29QLGOmkNLV1VYZk5XY4i/s05laMvl9f7nGRHxrfpRd6y/OKUYu224qjBoDCl5BNsw6g OVAMzssJAlFBqkuc8NPJihCVS/ELCY33VIbxmrBcnF91vNcGHEbuWhuJ6B7XjvpXEsvj JCVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:content-transfer-encoding:date :message-id:cc:to:from:sender:reply-to:subject:mime-version :dkim-signature:dkim-filter; bh=g0U3OpuHF1CVQo7od+Tsso7DBc2pL/976ROK5+ymkx4=; b=r1nMJJQGBXi4rUBntEKJQe1u8NghIQD/s686s+Vvhn05AUFvd+AJgfyv34Jr15Dv1N rZ8a2qw9laAorXUI80eNpvNEeYr5eVxddt54lSgSjsZQ8lCPKBbMsO868VTcLqqbM2xC mpvVQfc4zOabw80eOEzZbTN4SHcVCOyKZXf9Z4UhIgUJYRXGZ7H0VR9hQoj2Ng2Oq/6K 4Pg/M+TEAt0ePpOR346P3+AzBhlOlnW7cib5HbD/qXlEItfySckzUrPOl+c+01HpzZph N5AKVOO2JzIsHv865RUa0GRzl0is5N4GSbspts6bZz30GIaNZqCE/ZhJ2bIGLf5iUTkm ikJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=UiSbICbK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i5si3845482edf.408.2021.04.01.00.03.19; Thu, 01 Apr 2021 00:03:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=UiSbICbK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233522AbhDAHAY (ORCPT + 99 others); Thu, 1 Apr 2021 03:00:24 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:22780 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233195AbhDAHAI (ORCPT ); Thu, 1 Apr 2021 03:00:08 -0400 Received: from epcas3p4.samsung.com (unknown [182.195.41.22]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20210401070005epoutp014e7f5d8a15b1159f894f4ae3de75153a~xqcVIuX1j2383623836epoutp01K for ; Thu, 1 Apr 2021 07:00:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20210401070005epoutp014e7f5d8a15b1159f894f4ae3de75153a~xqcVIuX1j2383623836epoutp01K DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1617260406; bh=g0U3OpuHF1CVQo7od+Tsso7DBc2pL/976ROK5+ymkx4=; h=Subject:Reply-To:From:To:CC:Date:References:From; b=UiSbICbKQsVXTBMDDlSPs3UJHRTSkoVfu+lQRZOoN42xuLmk1hXlMx7otEX2qEHyL 8+og2PV9ofsFAXpXdM+vOstUVMKRKlWZE5EEJndBeacO7/wXoOsCw4rdywHoIEFJzn kl7HJGLLCSe6esnCqcSdd2qszJXFLZKpfCxfdRqs= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas3p3.samsung.com (KnoxPortal) with ESMTP id 20210401070002epcas3p3c736459ea4bf7e83c35bc17b974bfcb1~xqcRubRCO0642806428epcas3p3E; Thu, 1 Apr 2021 07:00:02 +0000 (GMT) Received: from epcpadp3 (unknown [182.195.40.17]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4F9vFZ1rHWz4x9Pp; Thu, 1 Apr 2021 07:00:02 +0000 (GMT) Mime-Version: 1.0 Subject: RE: [PATCH v4 2/2] scsi: ufs: Fix wrong Task Tag used in task management request UPIUs Reply-To: daejun7.park@samsung.com Sender: Daejun Park From: Daejun Park To: "cang@codeaurora.org" CC: ALIM AKHTAR , "asutoshd@codeaurora.org" , "avri.altman@wdc.com" , "beanhuo@micron.com" , "hongwus@codeaurora.org" , "jaegeuk@kernel.org" , "jejb@linux.ibm.com" , "kernel-team@android.com" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "nguyenb@codeaurora.org" , "stanley.chu@mediatek.com" , "sthumma@codeaurora.org" , "vinholikatti@gmail.com" , "ygardi@codeaurora.org" X-Priority: 3 X-Content-Kind-Code: NORMAL X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <1891546521.01617260402234.JavaMail.epsvc@epcpadp3> Date: Thu, 01 Apr 2021 15:44:19 +0900 X-CMS-MailID: 20210401064419epcms2p6b289c9ba573d15883e3e92ddcd233e11 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL X-CPGSPASS: Y X-CPGSPASS: Y X-Hop-Count: 3 X-CMS-RootMailID: 20210401064419epcms2p6b289c9ba573d15883e3e92ddcd233e11 References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Can Guo > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c ... > > req->end_io_data = &wait; > - free_slot = req->tag; > WARN_ON_ONCE(free_slot < 0 || free_slot >= hba->nutmrs); I think this line should be removed. Thanks, Daejun