Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp274257pxf; Thu, 1 Apr 2021 00:21:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwn8HPlsaxV/0OWvNnXKAIGnxcRkKLs9zG8eYPPBXmSo6YXAivCnqXqBkpAJsGQVcaMqtDU X-Received: by 2002:aa7:d484:: with SMTP id b4mr8311067edr.63.1617261687511; Thu, 01 Apr 2021 00:21:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617261687; cv=none; d=google.com; s=arc-20160816; b=Umrphlf4jy6byLGxm4IOj0DzoYQEOrVZnD+KFEhe7qa0ghnidwKGbwOe/Skdzqk5PF PbHj9bh6q3tYCRqNMfebYeFF6c97uG+L666s4wb0JVVqEm0K1CajfI8f2yJ8zf9whw60 ScTSd2U1GUkZ1UELYeVFLOAK1JQP/rk08KyPqHLPWlxqWCd4KZsmpgaZKcZcOa6GuZws ily8zJ72wOSKhQmcTRC/xCIUKM9agcU3O84wO0IqtSv3Nd6uRYeZN0lXTaSTagroPMiE F5w1033lSs/Bel1a3Lcm8lYERWh8/khX1RdpSdGM9q/S1T+e2Rg/f0GFLDtJLQcuI4d4 Ll5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=vlZ+vMQlZRuL8LM8chZeMjq7xPyflEjD//VALE5QuZ8=; b=Czf61qpS1cr3RmC1EjWC+zgU6oQcYskYsWGuIFOf9mdmT/WseY5z7NVsnTQnqGBvhf UWnVnuIGQkYi4zu6oeO3cKnbXTIx/bhdVLhLyZyrU125NMujPqlAvfYY1PgJfO2hBzyA L137KKeIHisGiaGMOu2JGAmAGmcSeyt9A4Q4Jyz8292TN74SuThAav0XEWRjVfnzG4Zh KLoOYcNtJJlCJBjiJ74BCuPaNsRkZuBaWz+rZ5A0yg/MJciCALXCEFzxNfLSToksIXGH fwpAsZmjKyi/WYKy8ILM7gutPkabYYDp5OTUlOPQAN21au2NFc/pVMGmfZnYlsdMImg7 9M/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="WFS/SqLj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j2si3634468ejv.381.2021.04.01.00.21.05; Thu, 01 Apr 2021 00:21:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="WFS/SqLj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233050AbhDAHSQ (ORCPT + 99 others); Thu, 1 Apr 2021 03:18:16 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:64067 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbhDAHSA (ORCPT ); Thu, 1 Apr 2021 03:18:00 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1617261480; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=vlZ+vMQlZRuL8LM8chZeMjq7xPyflEjD//VALE5QuZ8=; b=WFS/SqLjGOWmc71G7q+jewe6FZGw/68RVRt8f/4/m7clhb+OI3/+ZsjPQBSU8P2givmi9Um4 EawY7j925U9eIMQW0EymztU1nR7W/ZSB54Pnu8waKSCVURHuYARncqLpoC/wpAp5xoB7OanE gUGDYSFNgVpq/QpGmlNkzUoY9kM= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 6065739c0a4a07ffda8cb160 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 01 Apr 2021 07:17:48 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AA19FC43462; Thu, 1 Apr 2021 07:17:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 170D0C433CA; Thu, 1 Apr 2021 07:17:47 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 01 Apr 2021 15:17:46 +0800 From: Can Guo To: daejun7.park@samsung.com Cc: ALIM AKHTAR , asutoshd@codeaurora.org, avri.altman@wdc.com, beanhuo@micron.com, hongwus@codeaurora.org, jaegeuk@kernel.org, jejb@linux.ibm.com, kernel-team@android.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, nguyenb@codeaurora.org, stanley.chu@mediatek.com, sthumma@codeaurora.org, vinholikatti@gmail.com, ygardi@codeaurora.org Subject: Re: [PATCH v4 2/2] scsi: ufs: Fix wrong Task Tag used in task management request UPIUs In-Reply-To: <1891546521.01617260402234.JavaMail.epsvc@epcpadp3> References: <1891546521.01617260402234.JavaMail.epsvc@epcpadp3> Message-ID: X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-04-01 14:44, Daejun Park wrote: > Hi, Can Guo > >> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > ... >> >> req->end_io_data = &wait; >> - free_slot = req->tag; >> WARN_ON_ONCE(free_slot < 0 || free_slot >= hba->nutmrs); > I think this line should be removed. > Oh, yes, will remove it in next version. Thanks, Can Guo. > Thanks, > Daejun