Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210401062424.991737-1-wanjiabing@vivo.com>
In-Reply-To: <20210401062424.991737-1-wanjiabing@vivo.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Thu, 1 Apr 2021 16:19:38 +0900
Message-ID: <CAM9d7ciHzUDJc0KutAKoBqB2RA7pheB44=xv7dZ97=UqdNtv_g@mail.gmail.com>
Subject: Re: [PATCH] tools: perf: util: Remove duplicate struct declaration
To:     Wan Jiabing <wanjiabing@vivo.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>, kael_w@yeah.net
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello,

On Thu, Apr 1, 2021 at 3:25 PM Wan Jiabing <wanjiabing@vivo.com> wrote:
>
> struct target is declared twice. One has been declared
> at 21st line. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

I think we can move all the forward declarations to the top
(and sort them) as well.

Thanks,
Namhyung


> ---
>  tools/perf/util/evsel.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> index 6026487353dd..998e5b806696 100644
> --- a/tools/perf/util/evsel.h
> +++ b/tools/perf/util/evsel.h
> @@ -157,7 +157,6 @@ struct perf_missing_features {
>  extern struct perf_missing_features perf_missing_features;
>
>  struct perf_cpu_map;
> -struct target;
>  struct thread_map;
>  struct record_opts;
>
> --
> 2.25.1
>