Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     "'Muhammad Usama Anjum'" <musamaanjum@gmail.com>,
        "'Sergey Senozhatsky'" <sergey.senozhatsky@gmail.com>,
        "'Steve French'" <sfrench@samba.org>,
        "'Hyunchul Lee'" <hyc.lee@gmail.com>,
        "'open list:COMMON INTERNET FILE SYSTEM SERVER \(CIFSD\)'" 
        <linux-cifs@vger.kernel.org>,
        "'open list:COMMON INTERNET FILE SYSTEM SERVER \(CIFSD\)'" 
        <linux-cifsd-devel@lists.sourceforge.net>,
        "'open list'" <linux-kernel@vger.kernel.org>,
        <kernel-janitors@vger.kernel.org>, <colin.king@canonical.com>,
        <dan.carpenter@oracle.com>
In-Reply-To: <20210401075531.GA2766105@LEGION>
Subject: RE: [PATCH] cifsd: fix memory leak when loop ends
Date:   Thu, 1 Apr 2021 17:17:13 +0900
Message-ID: <003901d726cf$6b75d890$426189b0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQG8FoHjOwNMvoZKP6UmJNrFtYqTewIzYq1UqsPWbrA=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20210401075539epcas1p3b7cb52923217b212c80185aab135fe22@epcas1p3.samsung.com>
        <20210401075531.GA2766105@LEGION>
Precedence: bulk

> 
> Memory is being allocated and if veto_list is zero, the loop breaks without cleaning up the allocated
> memory. In this patch, the length check has been moved before allocation. If loop breaks, the memory
> isn't allocated in the first place. Thus the memory is being protected from leaking.
> 
> Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
I will apply. Thanks for your patch!