Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210401062517.28832-1-dmugil2000@gmail.com>
In-Reply-To: <20210401062517.28832-1-dmugil2000@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 1 Apr 2021 12:24:50 +0300
Message-ID: <CAHp75VfgL0KW0fetgE3NuBb4itMK1oY+yLmr1xDYkn390hCscg@mail.gmail.com>
Subject: Re: [PATCH] iio: adc: bcm_iproc_adc: Use %s and __func__
To:     Mugilraj Dhavachelvan <dmugil2000@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        linux-iio <linux-iio@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Apr 1, 2021 at 9:27 AM Mugilraj Dhavachelvan
<dmugil2000@gmail.com> wrote:
>
> Change function's name to %s and __func__ to fix checkpatch.pl errors.

No, just drop the __func__ completely. First of all, we have a device
name, and uniqueness of the messages in the driver should guarantee
easy findings. Second, specific to _dbg() variants, with enabled
Dynamic Debug it can be chosen at run time!

I recommend going through all drivers and drop __func__ near to
dev_dbg() and pr_debug().

-- 
With Best Regards,
Andy Shevchenko