Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp355056pxf; Thu, 1 Apr 2021 03:01:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwI0gvgUIoppCmBf0xW3FCiFGZMS8xSPFWECYY4vwvdpRZa9zJbhi8FNMsh+l/Rk/uby2pz X-Received: by 2002:a17:906:cc89:: with SMTP id oq9mr8128203ejb.258.1617271286665; Thu, 01 Apr 2021 03:01:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617271286; cv=none; d=google.com; s=arc-20160816; b=aGWpn39XDr80tiQrZn9jdjCVEm1dY5R3baxuu8QUC0C8DGAz9t1Y4TjbkZ1d0nBfYs baeC2s4Td0qIcYRxxciOR0Cb216RHe2cB5MpnRFHBHOK1/ROR8m3v72wNjvQZtIcMgDF 6cWtPS3TRefUxdNnqVe+it3FvkBKprGz73lP1SngiJKKk1UYL5HsPsApb+/n12XIGncF GlQEaaO2fsgvbBwP/JeIS/XABjiHuVNxJjVe1HpOyI2Gsl6K9XZlnp/OXh9FgpWeiD+I +otMUCSBMrsh7DrgYBjJOZ6PeWaqL8drevWNXAIZpMVdZ/796d10OBm4CmtUHPDwuBGm swwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=wWjJsnkP44P2xn2pmp2GA5cCLWsnCb9Ph8lioc7zkMA=; b=a8RQrvlpRf2d82qxSgBvdqztTQvJpMGODpw8QyP6sRxPeYf9o9taHOR6dcczEliQ8o iCCACGAsatnTMjMOF+G3ALHnyYUzvjXClzzQyKT4SHHGkipIAEe6FEySD7nuGZCXzbm1 dBE8cdyCsD37j0nqctur3XwIQgI7TMpm7fR3KK7hLF8LXhtci9gBSxOYeX6YTdI8Y/G2 zrN9UoJ5RFI7jwPeDS8fjqOt56cDmnHhOCM/mkhvSdFOcWn+yPss3uTl3ZymbGwv2xMm 12NjB8ktHEoLWLWwjRKJYauxqr1BjR+wnpEeM6QJXtr6gVF5HX/W+wvQdOgZdVXwfCrU 3bAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a7si4382616edm.320.2021.04.01.03.01.03; Thu, 01 Apr 2021 03:01:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233736AbhDAJ6H (ORCPT + 99 others); Thu, 1 Apr 2021 05:58:07 -0400 Received: from smtprelay0145.hostedemail.com ([216.40.44.145]:46378 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233553AbhDAJ5l (ORCPT ); Thu, 1 Apr 2021 05:57:41 -0400 Received: from omf09.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id D6D721821939A; Thu, 1 Apr 2021 09:57:39 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA id E24EE1E04DB; Thu, 1 Apr 2021 09:57:38 +0000 (UTC) Message-ID: <44730b7154cba578c5c342f1919d0937009985fa.camel@perches.com> Subject: Re: [PATCH 49/49] staging: rtl8723bs: remove obsolete macro From: Joe Perches To: Fabio Aiuto , gregkh@linuxfoundation.org Cc: dan.carpenter@oracle.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Thu, 01 Apr 2021 02:57:36 -0700 In-Reply-To: <1c7cdfcf488e5dc5bc5c3c29733b0d53caee71fb.1617268327.git.fabioaiuto83@gmail.com> References: <1c7cdfcf488e5dc5bc5c3c29733b0d53caee71fb.1617268327.git.fabioaiuto83@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E24EE1E04DB X-Spam-Status: No, score=0.10 X-Stat-Signature: i16kjuuxdf6pyfcafokbc7k1wb5bhuyk X-Rspamd-Server: rspamout01 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/1pH22N4+o4Qcx1qZTrXkESthNYQEGMPA= X-HE-Tag: 1617271058-622136 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-04-01 at 11:21 +0200, Fabio Aiuto wrote: > remove obsolete macro RT_TRACE [] > diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h b/drivers/staging/rtl8723bs/include/rtw_debug.h [] > -#ifdef DEBUG_RTL871X > - > -#if defined(_dbgdump) && defined(_MODULE_DEFINE_) > - > - #undef RT_TRACE > - #define RT_TRACE(_Comp, _Level, Fmt)\ > - do {\ > - if ((_Comp & GlobalDebugComponents) && (_Level <= GlobalDebugLevel)) {\ > - _dbgdump("%s [0x%08x,%d]", DRIVER_PREFIX, (unsigned int)_Comp, _Level);\ > - _dbgdump Fmt;\ > - } \ > - } while (0) > - > -#endif /* defined(_dbgdump) && defined(_MODULE_DEFINE_) */ > -#endif /* DEBUG_RTL871X */ Maybe remove all of these too $ git grep DEBUG_RTL871X drivers/staging/rtl8723bs/core/rtw_debug.c:#ifdef DEBUG_RTL871X drivers/staging/rtl8723bs/core/rtw_debug.c:#endif /* DEBUG_RTL871X */ drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:#ifdef DEBUG_RTL871X drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:#ifdef DEBUG_RTL871X drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:#ifdef DEBUG_RTL871X drivers/staging/rtl8723bs/include/autoconf.h:/*#define DEBUG_RTL871X */ drivers/staging/rtl8723bs/include/rtw_debug.h:#ifdef DEBUG_RTL871X drivers/staging/rtl8723bs/include/rtw_debug.h:#endif /* DEBUG_RTL871X */