Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp360466pxf; Thu, 1 Apr 2021 03:09:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwO+2SObPP7ByZwiqHsuIw2GeRUKkT+O0lpQ1DlfRNJSE5XJfVSotuvKiEOGIMU2mu3nJ4i X-Received: by 2002:a17:906:68c5:: with SMTP id y5mr8356649ejr.371.1617271748834; Thu, 01 Apr 2021 03:09:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617271748; cv=none; d=google.com; s=arc-20160816; b=QwZCrsTGouwdsk4VCMDlGL66xjWCn9WS9Ixp2XETGpHdbyenyQjY7RpYP1t8zWNyMe GiRLgU1Os8/0j/dj+fkhKBUM2wVOQqxbGvZBHU679xUJosepKLVTD95zYtt3rMFj/zQ2 SSKnjSxiSMWwNC2wKeHKQQ5zu3I8Tg9eAgZoInu8C77wQ/IzNQLKn8t6goICdUet5vHv CWQ9RCs4zPCKqXY6Hi0dN7t9vDcwVrmUZVMvW4SMIKPBAemNH93IWqXXOMdbEXoK5uka kyvbWwCJbZsUpw9TWoI6nhv+MAtSz2cY6ki0pQKoR2RSyRLxqd7SPSyqHSXH0INQBkcE /3RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :organization:subject:cc:to:from:date:content-transfer-encoding :mime-version; bh=9Y9DcovCy2dVeS9pBhzo2FwF1WkG0Svudp7jXxgfiSo=; b=uTm1pPqKjeVulmZ97ch6d5Iz02YtkUbdxYjz4kTSUfckazb5FAE6ei7Av99YdY7m9A xpSsOEr/Gq2NnQ5A0+L/seBI3W9WKQapnTBUxCY5m17dzp6VTElHKIhRqCWwvN8dT5f7 ORskoqqj+qlW4Jn3dB6E2qu3uGF9hIy1xFgZ6koaZVH8jm36klqH9yqLfXIxXLQwz0zN /fylnpPuzlarIStHaf7st+KSK4yAwCk1T1Fad3bWxeg+4cEAKWetWXpFYJ7AXCpsDG0a dLIDW39TcJ79gZJcPYHqbcM16OWSwRjmQjvgYKyvo6JSzMOJVa54owP9UttNYrrz7KGf ZWtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si3518965ejb.59.2021.04.01.03.08.46; Thu, 01 Apr 2021 03:09:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233780AbhDAKHX (ORCPT + 99 others); Thu, 1 Apr 2021 06:07:23 -0400 Received: from mxout70.expurgate.net ([194.37.255.70]:51295 "EHLO mxout70.expurgate.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234004AbhDAKHD (ORCPT ); Thu, 1 Apr 2021 06:07:03 -0400 Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.90) (envelope-from ) id 1lRuDp-0005br-Lw; Thu, 01 Apr 2021 12:06:41 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90) (envelope-from ) id 1lRuDo-000Ffc-EW; Thu, 01 Apr 2021 12:06:40 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id D96B0240041; Thu, 1 Apr 2021 12:06:39 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 44BAB240040; Thu, 1 Apr 2021 12:06:39 +0200 (CEST) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id BB94C20072; Thu, 1 Apr 2021 12:06:38 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 01 Apr 2021 12:06:38 +0200 From: Martin Schiller To: Xie He Cc: "David S. Miller" , Jakub Kicinski , Jonathan Corbet , Krzysztof Halasa , Linux X25 , Linux Kernel Network Developers , linux-doc@vger.kernel.org, LKML Subject: Re: [PATCH net-next v4] net: x25: Queue received packets in the drivers instead of per-CPU queues Organization: TDT AG In-Reply-To: References: <20210328221205.726511-1-xie.he.0141@gmail.com> Message-ID: <21ec9eafa230f2e20dd88d31fd95faa0@dev.tdt.de> X-Sender: ms@dev.tdt.de User-Agent: Roundcube Webmail/1.3.16 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.dev.tdt.de X-purgate-type: clean X-purgate-ID: 151534::1617271601-0000718E-4D93F7FF/0/0 X-purgate: clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-03-31 20:41, Xie He wrote: > Hi Martin, > > Could you ack this patch again? The only change from the RFC version > (that you previously acked) is the addition of the "__GFP_NOMEMALLOC" > flag in "dev_alloc_skb". This is because I want to prevent pfmemalloc > skbs (which can't be handled by netif_receive_skb_core) from > occurring. > > Thanks! Hi! Sorry for my late answer. Can you please also fix this line length warning? https://patchwork.hopto.org/static/nipa/442445/12117801/checkpatch/stdout - Martin