Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp374368pxf; Thu, 1 Apr 2021 03:34:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfl2SFdg1pDhgXFo+q1UaNUcGoi9ct3mdb7GyS6essHYh43baosRhYRloLvDCSMW46tQyC X-Received: by 2002:a50:fa04:: with SMTP id b4mr9236180edq.293.1617273240811; Thu, 01 Apr 2021 03:34:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617273240; cv=none; d=google.com; s=arc-20160816; b=hDwnzI4F8JtPA3fJQWDdVn5mScE1I8xa1guJhG3i5L8VHh2sQO3qnrM1OpFXDIEtes 16YrHIusujx8z3T55I9BkxXHN2KI4R+kdWQX2hgjIim4pj3u+cgAL8F4prFS8lfoRRK7 B4Z3//NMDLZN0pP6int6wWWOlwvaY9mLDPKI1Irx8qVQ0/TjYAeilJ6Id0UlUc3xDfKr ifkESWAMuonKhC2MdovBfdvIw3gFI9KPLC6pDSXeftCvyDdBYjTk8nGrohQcwFZYj7mM KfNtqPVQoGl/oMiVSeukqfDkkuJFqPXKcrWAbpbKVn06AEmQLgjVtDMm6W3/9uuGF2nx cE9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Nzfku92u3HqcFEyNz52mIjkXdSuLXDfoP1dKTDBmDQA=; b=dn0kDi3vT0ncB6Ulu2TANaQmXVetR8Fjv4t+uGt2wtawllIix4CwIVX3e+ksOaqEeJ UCU4GGbOG6vb7hbiQu0luAPiY+ztPJXQiMYLKVnIt/qInqjOREMjoldjbhSr6uer06WO KKQ1e53soH7UKX0Y8qS+bU97+6MAvNZGNB3s8t5Hho2vfQxgjL4O69jtQpzKIW2FufuN ENfS5RAaVSyEpFk/3ffvBKr+ZC5LPRFg1elOVRP6+kl9a2Q8EIcxc5pa96RBr33NIc9s 20l8dWJ/SQL8RJpCvhQuGfgaVzWxf00cfCysHL3J05UDrjOxlX1k5rdz/H+DXGqXE+cj XavA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h16si4062605ejk.221.2021.04.01.03.33.38; Thu, 01 Apr 2021 03:34:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234376AbhDAK2N (ORCPT + 99 others); Thu, 1 Apr 2021 06:28:13 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:15570 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234240AbhDAK1x (ORCPT ); Thu, 1 Apr 2021 06:27:53 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F9zp764F9z17P9w; Thu, 1 Apr 2021 18:25:03 +0800 (CST) Received: from huawei.com (10.175.103.91) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Thu, 1 Apr 2021 18:27:06 +0800 From: Yang Yingliang To: , CC: , Subject: [PATCH -next] media: ti-vpe: sc: remove redundant dev_err call in sc_create() Date: Thu, 1 Apr 2021 18:30:15 +0800 Message-ID: <20210401103015.1555941-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is an error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/media/platform/ti-vpe/sc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/platform/ti-vpe/sc.c b/drivers/media/platform/ti-vpe/sc.c index 98f95082a6fd..0202d278523f 100644 --- a/drivers/media/platform/ti-vpe/sc.c +++ b/drivers/media/platform/ti-vpe/sc.c @@ -294,10 +294,8 @@ struct sc_data *sc_create(struct platform_device *pdev, const char *res_name) } sc->base = devm_ioremap_resource(&pdev->dev, sc->res); - if (IS_ERR(sc->base)) { - dev_err(&pdev->dev, "failed to ioremap\n"); + if (IS_ERR(sc->base)) return ERR_CAST(sc->base); - } return sc; } -- 2.25.1