Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp376174pxf; Thu, 1 Apr 2021 03:37:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgz3ngwsaQH0hcCtzcul6JOPWsGMziqduG7glLB2Z8SlTdfuXAbh7n6g/Ixkkan+e0VPK4 X-Received: by 2002:a17:907:c16:: with SMTP id ga22mr8400858ejc.120.1617273429682; Thu, 01 Apr 2021 03:37:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617273429; cv=none; d=google.com; s=arc-20160816; b=pyLMBYe59Qwshifv2ZQezBG1srvTrOtEBxMliRiu7jU3ofV19OohHRBel4AL70rYnr 3L0o8j7d18doRf30KCTKOsbinIJv+HJuD+4+OCt3EqLguaPLkXWt2130fUHeH6lSbnZ4 TgjUnjOWTrCNUyKhkx6/bW104Xa+rKHH3yMZeguT0ajl8gxbjIsd50p9GvsXaVma07i0 lrh+/QamcH4sO4u+MwEAqz76BDJLimReB13On34hFDItYMkMev8UV+yCAq9FmIjAuj9N t08vLiyiqlasKqJ/1qrwxm35n5tHoh0uDlhrr3HY/cP1/9KFyrfLrOrAY0lxtLwdiV5s uqTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=h7paABFxbhKtfZVqEPpjt/gCimk69Y9udxQLnFgVP9g=; b=i1A0aeSU09x+Qi2C8dNOCNLE4DTQJbN+YRPjYqVzfY34Qu2rIZLE8puDsli5WOKvhd hcFdqddAXfqBu3ciuzfYMvKkoWcsXaJXq7R8WGAmYYKDRUq8aiyjhI8+Q4JNKFnGHDo8 xGnJuvSd/HhgfiDS1CM3IiC7CsGgcXlWQ6HSWX0B+vDFncNuuW0kqrXZzQLSpuTQtm3S jReqYlXKWLCrZKCnfDjxMmwhG2+fJJDsDztWhtUuDzKlKBPVoFFz597FFD8qXxcqu/5M zzsMan6TWzhPXFtHkc4tBeZVZCVM0oevrKaBk+z3QQph93PIuCTrJa0jMqDtfzyEtIp2 81LA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hy25si3784643ejc.333.2021.04.01.03.36.41; Thu, 01 Apr 2021 03:37:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234153AbhDAKcz (ORCPT + 99 others); Thu, 1 Apr 2021 06:32:55 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:15571 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234105AbhDAKc0 (ORCPT ); Thu, 1 Apr 2021 06:32:26 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F9zw90gJhz17PPH; Thu, 1 Apr 2021 18:30:17 +0800 (CST) Received: from huawei.com (10.175.103.91) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Thu, 1 Apr 2021 18:32:19 +0800 From: Yang Yingliang To: , , CC: , Subject: [PATCH -next] media: camss: csiphy: Remove redundant dev_err call in msm_csiphy_subdev_init() Date: Thu, 1 Apr 2021 18:35:00 +0800 Message-ID: <20210401103500.1558058-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is an error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/media/platform/qcom/camss/camss-csiphy.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c index 6ceb6d7d53d1..b3c3bf19e522 100644 --- a/drivers/media/platform/qcom/camss/camss-csiphy.c +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c @@ -593,20 +593,16 @@ int msm_csiphy_subdev_init(struct camss *camss, r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]); csiphy->base = devm_ioremap_resource(dev, r); - if (IS_ERR(csiphy->base)) { - dev_err(dev, "could not map memory\n"); + if (IS_ERR(csiphy->base)) return PTR_ERR(csiphy->base); - } if (camss->version == CAMSS_8x16 || camss->version == CAMSS_8x96) { r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[1]); csiphy->base_clk_mux = devm_ioremap_resource(dev, r); - if (IS_ERR(csiphy->base_clk_mux)) { - dev_err(dev, "could not map memory\n"); + if (IS_ERR(csiphy->base_clk_mux)) return PTR_ERR(csiphy->base_clk_mux); - } } else { csiphy->base_clk_mux = NULL; } -- 2.25.1