Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp700340pxf; Thu, 1 Apr 2021 11:13:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzf4AtySb7tJrtrJxnA6S8+WLYvSVJgGccOgGk9Z09e1W14REeiSJv6R+0uKUVigFjNXTjo X-Received: by 2002:a17:907:9862:: with SMTP id ko2mr10291202ejc.222.1617300817557; Thu, 01 Apr 2021 11:13:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617300817; cv=none; d=google.com; s=arc-20160816; b=WwTKwe0fR1wvUbodXAvDOoE+vwwtn/DPAnHgq5yBLr/7HksuVkW7Gnqj56LW1OP6jv Sdj0/beMZeCtRPK9zVL1pdZDLFjg8g15mHNBWfQ41/psDScwuANkLHd3jXzl96zYRC+s TVoLlmQ28GEdX7kt/AibojpF+oRpUpo0Olwfvs+jdVA/dONy76uEoHYi4WYcLHc3irUH Ja8SG4siUQXTOH/iOg9RgcyoAlc06Gs3HTF7The6DHCBB/JH1587VSCCFI8blOP1uEKb 8pGtJgDJULBUDSjibtdcqzXmfI9dPjJT2Vql8OdVDd33FXSHJNzyxAVCxlZ0kDYHum0e SFvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:ironport-sdr :ironport-sdr; bh=wjKks1CtYmAIJb5+txGWwbn3bWvXWx8FN6klJ10k1Gw=; b=EY1mWJsDzauCjbgwALy4STam9vU3uzYuHUnArvCxS9wlay8a0vDt9HUp+n4qb64ogM 00c472LrMiXpVEZzGqcqVemjuKyOxKCFtr+kpcroJ/eumKHILOxu0kJ4aXOm23VUhfYT +koP1Yefx67jkGpyV+J2B5vjyahL7QwMkYom0y/PdkgNib4KFGO0Ys0+JNswjpYgEDjq ylMDxBWuNofyHwEKqHR39TqQeD0p/K4XyekG655/W4l7BX8mtu90qfywK7YqfWxpKUF4 D3FU1zKc92lO2mlPuTOwyX9EKCIAD0UpzuMobMnXm4LG0aV2IyBCkaXmdeP8s+THPRr2 PJTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r20si4737509edw.406.2021.04.01.11.13.14; Thu, 01 Apr 2021 11:13:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234717AbhDASMr (ORCPT + 99 others); Thu, 1 Apr 2021 14:12:47 -0400 Received: from mga09.intel.com ([134.134.136.24]:59663 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235232AbhDARzx (ORCPT ); Thu, 1 Apr 2021 13:55:53 -0400 IronPort-SDR: yOaaoXReRAjs1GJCIZ7v0aQLhAJPliTkHblGWrkL42eivIbjhcc5VZXHRqxSKoRzF0PV5XPMED TQiL+TXrpH4A== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="192359359" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="192359359" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 07:33:09 -0700 IronPort-SDR: nYAME5euVFgWBohmaIqvNezC9mKg/smE496aAGPx+sbu+lfxXveyfBZfIcyJnKRRlOy1EGDGD6 ytxU5FlgYepQ== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="377721508" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.25]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 07:33:09 -0700 Subject: [PATCH v4 0/4] cxl/mem: Fix memdev device setup From: Dan Williams To: linux-cxl@vger.kernel.org Cc: Ben Widawsky , Jason Gunthorpe , linux-kernel@vger.kernel.org, vishal.l.verma@intel.com, ira.weiny@intel.com, alison.schofield@intel.com Date: Thu, 01 Apr 2021 07:33:09 -0700 Message-ID: <161728758895.2474381.12683589190335430004.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.18-3-g996c MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes since v3 [1]: - Drop cxl_memdev_activate(). An open-coded pointer assignment is sufficient relative to cdev_device_add() publishing the device (Jason) [1]: http://lore.kernel.org/r/161714738634.2168142.10860201861152789544.stgit@dwillia2-desk3.amr.corp.intel.com --- A collection of fixes initially inspired by Jason's recognition of dev_set_name() error handling mistakes on other driver review, but also from a deeper discussion of idiomatic device operation shutdown flows. The end result is easier to reason about and validate. Thank you, Jason. The sysfs_emit() fixup and unpublishing of device power management files are independent sanity cleanups. --- Dan Williams (4): cxl/mem: Use sysfs_emit() for attribute show routines cxl/mem: Fix synchronization mechanism for device removal vs ioctl operations cxl/mem: Do not rely on device_add() side effects for dev_set_name() failures cxl/mem: Disable cxl device power management drivers/cxl/mem.c | 141 +++++++++++++++++++++++++++++++---------------------- 1 file changed, 82 insertions(+), 59 deletions(-) base-commit: a38fd8748464831584a19438cbb3082b5a2dab15