Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp703631pxf; Thu, 1 Apr 2021 11:18:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQQm480srZy2AMb/8Swo5irn1ziSP034dqlwZuiw/ncSgxfvQeguH1fVl1i2CJitaQeaQo X-Received: by 2002:a02:6c8d:: with SMTP id w135mr9062978jab.125.1617301090510; Thu, 01 Apr 2021 11:18:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617301090; cv=none; d=google.com; s=arc-20160816; b=DJxOZzW5trXlmSBSITYnsLQAsTYSVwnV3uPW1/ySqcDsQUBtCE2IY3v0QdGmkro3K9 QYXhZSUZ+z7/k8DGjo2Z0O1B9ZzDZ+Mewkr7mfzxwm6YU/QNiljRUs6JO+5LOhM2NxDQ n++DTABNzmEj5+FY2eUvyQQMo6GEYLg/vfI4leqTbES45IESCOhegdyAOJq3V/FdABCJ DnMT8GQy14sHXRLb+lrR3FoAy3lN0pODN9NgnF7hb3P/yungbyZvoXNo49mOkxOUxOs6 q7PVa+otpC3M8t2vL36blyGjBpVGrUr/ur1eDKLqS0cAbfIx9GiRMmjgyIjXBNTxUMFN cN2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:dkim-signature; bh=HQiqujjUOZZ6yCPa12VOfuQ6GYJlXaZRf2XjeTsrXcQ=; b=DgPAOtT7bXjOzNdUahUNPnysZv0CYFx6If9ZqHkgS3fhda+Cvm08WNM3c4DaI+LRL1 Xj/dPv/DbCJT+Fp4yYIKhU1PCYWnOEupZuTA2XnxV+QiryDqodMAjJNpyQxoU9BfxsKE b4D4YXIeczdZ/ez2HJBzqvuduQSsMskXOmpUmtfB2MtB5Ti7oafPmALMhnR7rMHYPpS7 Fsbsek4MFQXDEVsw1Tu1QWK25MT2a17GnXGV2wGfm9Isrsm1690Uu2NesspoCmkAIKF6 q0qLb//N/QZhwUW4WUwSHNsdZIacLBvw2syX2zMu38Iqt/ZC0ZG16R0YMsXyVYMEM0AL D74g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b="C/6jpNW4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 12si5783398ilx.50.2021.04.01.11.17.56; Thu, 01 Apr 2021 11:18:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b="C/6jpNW4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239658AbhDASQo (ORCPT + 99 others); Thu, 1 Apr 2021 14:16:44 -0400 Received: from esa.microchip.iphmx.com ([68.232.154.123]:65126 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236242AbhDAR6J (ORCPT ); Thu, 1 Apr 2021 13:58:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1617299890; x=1648835890; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zGiPMKIR71RoJeRCsbyz2/Jkh0vjyf2K5BPASY5QkfU=; b=C/6jpNW4UaNGjXMnD+nD3RilY0qLZGA4A6b8U4Rl0Cy48i6Ufm7HznhV +U7QqsaupYRmjGLXSkVwjrgVmjtBRu3a8Ge/zhGINUIzd0zkwO+l0JJk1 6tZU005jcC/G+C3oHLZ/0+1JHCgNY14fuR55NV38JvHfHeOqztdcOwxxe VVZfIAQd74fFgfvM9lP2FmwrQqh/NFxA9ga4QF0cxAb3PV1QR7S/anJix A0YbBnMA5EU1ausPMsjMv91yQt8c8x5S0t1hHY6rQA2zIRxfDkI9Ow2ZH 9NkqIgoP1Fgu1bod892Xb2WaUAaU7cvyLL0xGh/1DyQieLxb08Xd1U6uG A==; IronPort-SDR: jC+RXg1VzIpUpBiJNFHJtK8gyMEW8DfuhUjgbWdG56DnDF0YOmja1Be374yE59UL8DGyzyPhQJ khyfjSG0uPpNY7yetMSP2SKxyFC8hoxOnvWJ1Rms+B43vYLI0/aX2RXbZU7vuteszoAMLFSuiT xPSgqHlSixpSvrZJTm6WVTofuSMugB/9/X7Ar8QH9uB+dnXqQY1er7ODNWNwhDkgdCCnUTdQJw 1IgjWsW+/40PxDkRVRRmLdEjegO398o465an9cujV8Z7H6VjgStO0lZURL4ucgBYLVblaSPqSJ pRk= X-IronPort-AV: E=Sophos;i="5.81,296,1610434800"; d="scan'208";a="49670700" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 01 Apr 2021 04:29:17 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 1 Apr 2021 04:29:17 -0700 Received: from ROB-ULT-M18282.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Thu, 1 Apr 2021 04:29:08 -0700 From: Eugen Hristev To: , CC: , , Eugen Hristev Subject: [PATCH 05/30] media: atmel: atmel-isc: specialize dma cfg Date: Thu, 1 Apr 2021 14:26:58 +0300 Message-ID: <20210401112723.189107-6-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210401112723.189107-1-eugen.hristev@microchip.com> References: <20210401112723.189107-1-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The dma configuration (DCFG) is specific to the product. Move this configuration in the product specific driver, and add the field inside the driver struct. Signed-off-by: Eugen Hristev --- drivers/media/platform/atmel/atmel-isc-base.c | 3 +-- drivers/media/platform/atmel/atmel-isc.h | 2 ++ drivers/media/platform/atmel/atmel-sama5d2-isc.c | 3 +++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c index 350076dd029a..ff40ee2e2759 100644 --- a/drivers/media/platform/atmel/atmel-isc-base.c +++ b/drivers/media/platform/atmel/atmel-isc-base.c @@ -716,8 +716,7 @@ static int isc_configure(struct isc_device *isc) rlp_mode = isc->config.rlp_cfg_mode; pipeline = isc->config.bits_pipeline; - dcfg = isc->config.dcfg_imode | - ISC_DCFG_YMBSIZE_BEATS8 | ISC_DCFG_CMBSIZE_BEATS8; + dcfg = isc->config.dcfg_imode | isc->dcfg; pfe_cfg0 |= subdev->pfe_cfg0 | ISC_PFE_CFG0_MODE_PROGRESSIVE; mask = ISC_PFE_CFG0_BPS_MASK | ISC_PFE_CFG0_HPOL_LOW | diff --git a/drivers/media/platform/atmel/atmel-isc.h b/drivers/media/platform/atmel/atmel-isc.h index 6becc6c3aaf0..d14ae096fbf6 100644 --- a/drivers/media/platform/atmel/atmel-isc.h +++ b/drivers/media/platform/atmel/atmel-isc.h @@ -150,6 +150,7 @@ struct isc_ctrls { * @hclock: Hclock clock input (refer datasheet) * @ispck: iscpck clock (refer datasheet) * @isc_clks: ISC clocks + * @dcfg: DMA master configuration, architecture dependent * * @dev: Registered device driver * @v4l2_dev: v4l2 registered device @@ -197,6 +198,7 @@ struct isc_device { struct clk *hclock; struct clk *ispck; struct isc_clk isc_clks[2]; + u32 dcfg; struct device *dev; struct v4l2_device v4l2_dev; diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c index f8d1c8ba99b3..6d9942dcd7c1 100644 --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c @@ -198,6 +198,9 @@ static int atmel_isc_probe(struct platform_device *pdev) isc->max_width = ISC_SAMA5D2_MAX_SUPPORT_WIDTH; isc->max_height = ISC_SAMA5D2_MAX_SUPPORT_HEIGHT; + /* sama5d2-isc - 8 bits per beat */ + isc->dcfg = ISC_DCFG_YMBSIZE_BEATS8 | ISC_DCFG_CMBSIZE_BEATS8; + ret = isc_pipeline_init(isc); if (ret) return ret; -- 2.25.1