Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] iio: adc: bcm_iproc_adc: Use %s and __func__
To:     Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        linux-iio <linux-iio@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20210401062517.28832-1-dmugil2000@gmail.com>
 <CAHp75VfgL0KW0fetgE3NuBb4itMK1oY+yLmr1xDYkn390hCscg@mail.gmail.com>
 <20210401113015.00006b70@Huawei.com>
From:   Mugilraj D <dmugil2000@gmail.com>
Message-ID: <a2ac91a9-54e3-2525-1e7e-00a26d3393e3@gmail.com>
Date:   Thu, 1 Apr 2021 20:22:47 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210401113015.00006b70@Huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 01/04/21 4:00 pm, Jonathan Cameron wrote:
> On Thu, 1 Apr 2021 12:24:50 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> 
>> On Thu, Apr 1, 2021 at 9:27 AM Mugilraj Dhavachelvan
>> <dmugil2000@gmail.com> wrote:
>>>
>>> Change function's name to %s and __func__ to fix checkpatch.pl errors.  
>>
>> No, just drop the __func__ completely. First of all, we have a device
>> name, and uniqueness of the messages in the driver should guarantee
>> easy findings. Second, specific to _dbg() variants, with enabled
>> Dynamic Debug it can be chosen at run time!
>>
>> I recommend going through all drivers and drop __func__ near to
>> dev_dbg() and pr_debug().
>>
> 
> Agreed.  Though beware that some maintainers will count this
> as noise and get grumpy.
> 
> I'm fine with such patches for IIO.

Sorry for the noise. I just seen the docs about dynamic debug.
So, if we use dev_dbg("log_msg") it will print statement like
filename:lineno [module]func flag log_msg, If I get it correctly.
And no need of specifying __func__ in dev_dbg() and dp_dbg() right!!

Jonathan do you have any TODO's?

> 
> Jonathan
>