Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp707048pxf; Thu, 1 Apr 2021 11:23:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZGqL6jmff72EV5Q0Begc+1TIh8NKOZv4aNFaspB0WgqoH9yGrc4pnYYLBQvv2EedBSaaE X-Received: by 2002:a92:4452:: with SMTP id a18mr7283959ilm.46.1617301407026; Thu, 01 Apr 2021 11:23:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617301407; cv=none; d=google.com; s=arc-20160816; b=NBYwVWsImSO/YUEhhlGNZCMV10jYdUCChMo5RmQQMX17B9FkdElZaqGUS/wkGptHJB /J/EvkXggGmGHV+DBjnDuxAl341zzilOW2mtqhBJ6hhta7U4ySm7qxEp3/unDAsJOeva +V8yLI6MYzi4m92X//nIyDmkDQbCVrwmrfFCyzG/gvWQqjJhxjRuZxmTgl9gRSya166y 4cV+6jAmLrUsqmdFUVPDHdZBgfW54vAanGHiT5TtVlQ86qHKSeFwqYHwMGGpxxZs8kev Ek5ehg/bm1j1X39wrnEC0PSdXUR2ErVD8xI/Zg4GwBMkEbVZVqgTuvwRnByBXkgK6wjc zTaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=iz2TpB7naaU3PCLy/XbmuGKh0b9HvwvTUFGq+CZiNMU=; b=HMaYUHVd4m30RpNL0kFz+Rw0G0NziFShvQyrHBxvSDUiL6iQKcQXSd+oYizL1MYb7L /fgwHuwIn7gbtdsDN3uj3npTiyOE4dwNIkChGqFwM1wFyh/PIzOcmQoxWH7QrOxog3/2 W4WmsaNC4052mohyHHhuyoSpxTIL2vo6wqFl3XfQU4uGbNlnbQWIipJqb4AvBeybGJ+z 7wSjodiw4KcMrzWeMMWCTcQ0pPlC0AknCZlcivxkIY+T8mNKFTkYDyF2g7J1Od3XQmCx OVxoAKmZcWuI8K+ZkNzCXa5yaOGYkTcXteuCGjobxpwBHJUl4ESKSQ5oJbrh/aBhU/B6 rczA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ADG7liQV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g6si5135622jaq.124.2021.04.01.11.23.12; Thu, 01 Apr 2021 11:23:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ADG7liQV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237124AbhDASWs (ORCPT + 99 others); Thu, 1 Apr 2021 14:22:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237225AbhDASDc (ORCPT ); Thu, 1 Apr 2021 14:03:32 -0400 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1653C0A3BD1; Thu, 1 Apr 2021 07:10:10 -0700 (PDT) Received: by mail-oi1-x231.google.com with SMTP id x207so1916150oif.1; Thu, 01 Apr 2021 07:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=iz2TpB7naaU3PCLy/XbmuGKh0b9HvwvTUFGq+CZiNMU=; b=ADG7liQV0cqVmaNb28NDFlgus/MZR3KP3BfoBoQbc3h8L4wDIlwBr72hPjo0nubrTE JVLR5T0PED/DU/3DibT3/6kkCv3wJg3G5JjVwfPa5ketoCq1504E8CdZ2d+eJrXp0msK iulCyod8bskseB2xs9Y+I6UzoSw+1+Ex13iarNXS8ppWOrjHNcjwSkoh6ZNQjrVtEA19 xNVqp1pG7I8XsjiC86HKohrtFH4kp5ZQFxFs8LmAB2L/R37arIZYYZHiIs4OJluczAOQ SRPvyQyUATWDkVzxQEkPToiN5UZ9Uz6jMGbZGPzjGptkxJ/cBy5xp3JOp8JyAEdTdWy9 2pwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iz2TpB7naaU3PCLy/XbmuGKh0b9HvwvTUFGq+CZiNMU=; b=dp4htqjHXyIgH8NY0XLpZLYR9YJ6j2Jd+jHwrNwsFZDJHZLPwWvoMFNQgqMQfN9KT5 RQeX3Ks6lh5beej4mu0SefBGbV+YHGNJ3vb99OqFVH24asEb/Nv3LQBG6Yw9Jt50Pqbl ifuIxoXx3QHW50E9ckVsYIMs626z4d5ge4kJFtOcV77lDLXLafKE/u9AY/HIcojUo0zv R2lPdHHxAdxUZ28VYZF9RqxAJWaxCQG71AeuWHMrykenkZoPqJn8ELNCLYFh0cOvJ0fe vI4UZ/13ap9J5ADU1h5h3HgQbOIbBFmMXPpIa230HI1Fz6Br5KV5BhQ0X1iUyVgFxKqS k75g== X-Gm-Message-State: AOAM530RlHl/+ioQ9yNcRa//LyVvh7gJfKttm5qTpmD7w/XgOMlJSwRw qRUyURGhSq5E6YObx9xs8cI= X-Received: by 2002:aca:b244:: with SMTP id b65mr6205217oif.134.1617286210133; Thu, 01 Apr 2021 07:10:10 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([8.48.134.56]) by smtp.googlemail.com with ESMTPSA id a7sm1114401ooo.30.2021.04.01.07.10.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Apr 2021 07:10:09 -0700 (PDT) Subject: Re: [PATCH net] net: udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...); To: Norman Maurer , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org Cc: pabeni@redhat.com, Norman Maurer References: <20210401065917.78025-1-norman_maurer@apple.com> From: David Ahern Message-ID: <27c645c8-c60d-0a92-e484-8b95d1bf437e@gmail.com> Date: Thu, 1 Apr 2021 08:10:08 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210401065917.78025-1-norman_maurer@apple.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/1/21 12:59 AM, Norman Maurer wrote: > From: Norman Maurer > > Support for UDP_GRO was added in the past but the implementation for > getsockopt was missed which did lead to an error when we tried to > retrieve the setting for UDP_GRO. This patch adds the missing switch > case for UDP_GRO > > Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.") > Signed-off-by: Norman Maurer > --- > net/ipv4/udp.c | 4 ++++ > 1 file changed, 4 insertions(+) > Reviewed-by: David Ahern