Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 1 Apr 2021 15:14:57 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     bvanassche@acm.org, dledford@redhat.com,
        linux-rdma@vger.kernel.org, target-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] IB/srpt: Fix passing zero to 'PTR_ERR'
Message-ID: <20210401181457.GA1634722@nvidia.com>
References: <20210324140939.7480-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210324140939.7480-1-yuehaibing@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (142.162.115.133) by BL1PR13CA0012.namprd13.prod.outlook.com (2603:10b6:208:256::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.8 via Frontend Transport; Thu, 1 Apr 2021 18:14:58 +0000
Received: from jgg by mlx with local (Exim 4.94)        (envelope-from <jgg@nvidia.com>)        id 1lS1qL-006rIK-Af; Thu, 01 Apr 2021 15:14:57 -0300
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b2bcd459-53e3-4905-98c0-08d8f53a0f4d
X-MS-TrafficTypeDiagnostic: DM6PR12MB4340:
X-Microsoft-Antispam-PRVS: <DM6PR12MB4340D4A6AC4A69A4E1562898C27B9@DM6PR12MB4340.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1751;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: BGRoVscKEOrVtecm0pFuqfHEi61e7YYJZnAiK+2j5TuDF47rA3nzU/uuIfS8pw0LKRa1tDRjNPGuPL3rvDyaONW4IH+EcHAaBHOzykuPhJ6TIJE7UDaejKAKKepJ3z7IBLpjUaK8bfxB7t6wiPRJF8ouNopSpdeDxkSZmqRADHFChA/5lKh/Pa5ewOtCF6YWcu1rylG5nkOJcDluc2fbBUdamnAjvaDe0Xl+prlSMzjWIgZnIUPWSZHZcMd0z20NaQb6bIQ6PC+nqCYTxrWSKQ/WiSBGNgGEBbPDZr3Mpsc2IWvAgbDw8teBKrQeK9Mq8sQGe7hkYbQJ11MOWTN88USLRL0uG0v5INDTld9PiEXEgj6V3L+hYLMB+RuHsHc8nn3Ljg4cd84M+TrTGXvbWsFAQBbv/NaSHritBXq0QtnUS3sfIfpvgGbbAOTydkIl6XC7US1z9DF9gfne1vcB4BCS1ppVhjogNtLtVzi+Xp8reMVWpPOnBs7qBnPpOF5sApxfqJyD9NU6ak8jQiXtfiatJOb3rUAWh8C8bUby8BIJAtnPwnuGhtA/VRG+3qrY3H/AjuFXcGxt7ai7GDN9f1dShl1zq5/bWASXd0x5D7QRXCvbVt8iWulKspy+Bj+wwxPYjH/6zkLRR1F/iy6ZN80b6G8Ex4rhhiXEFUzG/Uk=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3834.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(39860400002)(396003)(346002)(366004)(4744005)(2906002)(9786002)(1076003)(4326008)(5660300002)(66556008)(38100700001)(66476007)(66946007)(2616005)(36756003)(426003)(9746002)(8936002)(478600001)(83380400001)(26005)(33656002)(186003)(86362001)(8676002)(6916009)(316002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?daUX1ByD9SAStdedlH5ky3NgXEtemmEGMg0awTfF1etoYHMg+rHrmsjaKjRN?=
 =?us-ascii?Q?f1+ORVmsgxr5NFW4Vkbq7GGWmstEGWgMm1TPLZR/xZx7GOmFDARML/pB4VuQ?=
 =?us-ascii?Q?JnF7HfEolagvOH8M4Z0YFOx+g7iyJCfOQ6nBqTI9DaAq2hRTso4pKIhhtoIq?=
 =?us-ascii?Q?xZxmo/mPGSnAbpAgbDiOn0k4QaP4ucT+nM7XdcUTa7y1dlQTLB8BOhJn+AEV?=
 =?us-ascii?Q?pagTKMcO9LIvc6gWVgWgNICrN+EZ1te7GVEaoV90C2WlYKvk8Ez8Pu47VhK0?=
 =?us-ascii?Q?CKKE0PJEUtcLJaDuaUVUdFN0uFdpXjnLCyAcy8dQQy3wYvfEJjt3gwJW5aTu?=
 =?us-ascii?Q?JYJjie6IjCu6CDtB8UttzyZZoM25pxYe0+TaXIl9dxiid8rvvu9//dnEVr8m?=
 =?us-ascii?Q?4etU7zZ6DsEDUy4fFnbhKDVXEruNJyOKiohfsZHyKF/2F9+cKlk9npKiPlR7?=
 =?us-ascii?Q?A16Ol5BiIlGCBF7IhPLyJePEY0kdKAuUVhUp+wxl+HmN7HnrBNkY2Nq1RNnA?=
 =?us-ascii?Q?zGNatyKtdSBsh0NcGn9O/iW9OspXyeEVG5ZkFyb6NJFirKvYFt0mgk83zcXI?=
 =?us-ascii?Q?8TpMH/3TGYT37uKug2H4FLjfvSpQhdrPF3UI1vD/ZFWtgcdJE8LTRL57yWz0?=
 =?us-ascii?Q?N6GvnGH9sGPRbj4E1hhzmP+3pyd5Cz6JIDoooBMsfmB3Nl6/0WlorvZIpBWf?=
 =?us-ascii?Q?d8k8ygkiH/hVQXuyUN71+5eIv5mylXPtchHP1daDOEBTbkvxVGOYNwCoM3Ct?=
 =?us-ascii?Q?eJVD64K15MShJAEudW7GMyyJhmZTf6ICUKeXBZDgbhQbxe5VOcxzBtd9nS7T?=
 =?us-ascii?Q?+NpbWK3yFw7DDUjGUq2lDhkLe5EpK465k1YHdX7sNizfH+lOCqDqiHQdrGvX?=
 =?us-ascii?Q?TthrBLAZVR5Gvt5VqZk9zVH0CEI3EOTfNRXvjqUGugYDQvmcJ/okj7DRq6TW?=
 =?us-ascii?Q?TUBHX9+mLOlf3zEDfi8RHqdIuMnQZcxeU/rpd0SUZ/hwzurtGSbbWPtXLdcy?=
 =?us-ascii?Q?As9qIejPpTHf5lW2/JWyyZhUZCdOzQ/rKdBEteu32hUCS7mo1t0haoUH5rMH?=
 =?us-ascii?Q?3lSOGeFP2U20VGBU5L3rllprE1chjEhvYpq9hoyBxy9ler4d4LsGN/XQBOIf?=
 =?us-ascii?Q?BhecjWOa+crGXu06+ZX3nD/hQdMKgS5f4vEgq0wxZmL+Z3981RcbGar+YqmJ?=
 =?us-ascii?Q?VpOfoYg+N8SxVh34aWa3+yHBsNE2GZu9vUR4LbNZltynFRd+b2L5LuPOzscB?=
 =?us-ascii?Q?GkpZomygiMOJ8TBDMutaJKwPqezDMKWMBC9Vku/FEAC8/OIAnUCE/3TwTj0E?=
 =?us-ascii?Q?xhz5LubABT6Xwfz3m3N5vXGYvUMA8g+C9uRPcE379fWzQg=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2bcd459-53e3-4905-98c0-08d8f53a0f4d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3834.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2021 18:14:59.7311
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e/95U0URbYU8CP15EvTW2OlgLuW4rBSgW1gDLKPNz3vFYHPlABTUOxes5bQ2OAUp
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4340
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 24, 2021 at 10:09:39PM +0800, YueHaibing wrote:
> Fix smatch warning:
> 
> drivers/infiniband/ulp/srpt/ib_srpt.c:2341 srpt_cm_req_recv() warn: passing zero to 'PTR_ERR'
> 
> Use PTR_ERR_OR_ZERO instead of PTR_ERR
> 
> Fixes: 847462de3a0a ("IB/srpt: Fix srpt_cm_req_recv() error path (1/2)")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>  drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index 6be60aa5ffe2..3ff24b5048ac 100644
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -2338,7 +2338,7 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev,
>  
>  	if (IS_ERR_OR_NULL(ch->sess)) {
>  		WARN_ON_ONCE(ch->sess == NULL);
> -		ret = PTR_ERR(ch->sess);
> +		ret = PTR_ERR_OR_ZERO(ch->sess);

This whole flow is a mess, if someone fixes properly then fine, but
I'm not convinced returning 0 here is correct either.

Jason