Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210401103500.1558058-1-yangyingliang@huawei.com>
In-Reply-To: <20210401103500.1558058-1-yangyingliang@huawei.com>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Thu, 1 Apr 2021 13:44:15 +0200
Message-ID: <CAG3jFyupb==xBb19wdv=TKheKuS_TEojhsvzmAATJsh1VUrdzg@mail.gmail.com>
Subject: Re: [PATCH -next] media: camss: csiphy: Remove redundant dev_err call
 in msm_csiphy_subdev_init()
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        linux-media <linux-media@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Todor Tomov <todor.too@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hey Yang,

Thanks for the patch, feel free to add my r-b.

Reviewed-by: Robert Foss <robert.foss@linaro.org>

On Thu, 1 Apr 2021 at 12:33, Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> There is an error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/media/platform/qcom/camss/camss-csiphy.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c
> index 6ceb6d7d53d1..b3c3bf19e522 100644
> --- a/drivers/media/platform/qcom/camss/camss-csiphy.c
> +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c
> @@ -593,20 +593,16 @@ int msm_csiphy_subdev_init(struct camss *camss,
>
>         r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
>         csiphy->base = devm_ioremap_resource(dev, r);
> -       if (IS_ERR(csiphy->base)) {
> -               dev_err(dev, "could not map memory\n");
> +       if (IS_ERR(csiphy->base))
>                 return PTR_ERR(csiphy->base);
> -       }
>
>         if (camss->version == CAMSS_8x16 ||
>             camss->version == CAMSS_8x96) {
>                 r = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>                                                  res->reg[1]);
>                 csiphy->base_clk_mux = devm_ioremap_resource(dev, r);
> -               if (IS_ERR(csiphy->base_clk_mux)) {
> -                       dev_err(dev, "could not map memory\n");
> +               if (IS_ERR(csiphy->base_clk_mux))
>                         return PTR_ERR(csiphy->base_clk_mux);
> -               }
>         } else {
>                 csiphy->base_clk_mux = NULL;
>         }
> --
> 2.25.1
>