Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp722159pxf; Thu, 1 Apr 2021 11:47:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUlneqdUUltClfWgqA0kXllbn8D7C//gulHVtC5wL8MLNEfexSMXYLR9vWrFnN8tKi3hmd X-Received: by 2002:a17:906:abcd:: with SMTP id kq13mr10785846ejb.477.1617302865459; Thu, 01 Apr 2021 11:47:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617302865; cv=none; d=google.com; s=arc-20160816; b=iWMsQ/yOom21OcFW3WUA3VItznbn9yPwdcJTM9V8/Px7uDm+bnSIQFChf6K9uWsm/l oOx4+3oXJ4uR+llHVnddKVh5tA5KyC1nKoZzKN/cXa3+XPXZSluLrsbM+D9OEG9+4aUI lNTKZijnpVI6rUaxZlxYqTtM9gCZpKVkKf7daRd6XPAszbCV/nNOKBMAMGJrjcVWM6O1 gY0aw7o7MzprAWmv1U+pZDDrvGCBxh64PmBSspzOqwrIZZAmWd2zWWKFeoBGf9cNhSHk Bns2t8AA+GwKxI3NN2ZWCMrgt7bfbvjjsNdFo4uQcU2nTBg4UCiCZ1cLJG5uiLODpGcM Atag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ZEDIdZQM2L9RTXW3DJ3x28jYHeUh4iwAz6DCaCDKX8k=; b=P6VvUXRZdL4VOyogRJ5UNeL70kmtRXj7gmhWGfNnLIKrdJi1gC1u0zTjKFSs3xFqcP tlkXgzH7Vnn2ZtfPANGhuJY1H0QIa0NN6hrH98Jl7CWDyoEMcUaKE89+X/eERu9T7Ql0 GZitQJViqOPSjnSV5UPsTDLTmSQW9CzWxtmPfYhPrRTv6+lWe5AcY1Fxc+DKwiUex7Pl CQ3cz2OGpiyj1MsTz+dqtrPK6Zgya4vu4W7Y/byNBK1cbhosv8l7Lr3mGGBliq/Qdzv6 isLdmSlAyyA/r/IeepUyluaFatPpXXnAwc5Y3K/GemcGlEW4x2d6yN5XF1TTVMpJCKJe gDiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si4493744ejh.95.2021.04.01.11.47.22; Thu, 01 Apr 2021 11:47:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237387AbhDASqE (ORCPT + 99 others); Thu, 1 Apr 2021 14:46:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:53818 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235309AbhDASXj (ORCPT ); Thu, 1 Apr 2021 14:23:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1DABFB1E5; Thu, 1 Apr 2021 12:56:45 +0000 (UTC) From: Thomas Bogendoerfer To: Steven Rostedt , Ingo Molnar , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Cc: hch@lst.de Subject: [PATCH v3 1/4] MIPS: kernel: Remove not needed set_fs calls Date: Thu, 1 Apr 2021 14:56:34 +0200 Message-Id: <20210401125639.42963-2-tsbogend@alpha.franken.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210401125639.42963-1-tsbogend@alpha.franken.de> References: <20210401125639.42963-1-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org flush_icache_range always does flush kernel address ranges, so no need to do the set_fs dance. Reviewed-by: Christoph Hellwig Signed-off-by: Thomas Bogendoerfer --- arch/mips/kernel/ftrace.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c index 666b9969c1bd..8c401e42301c 100644 --- a/arch/mips/kernel/ftrace.c +++ b/arch/mips/kernel/ftrace.c @@ -90,7 +90,6 @@ static int ftrace_modify_code_2(unsigned long ip, unsigned int new_code1, unsigned int new_code2) { int faulted; - mm_segment_t old_fs; safe_store_code(new_code1, ip, faulted); if (unlikely(faulted)) @@ -102,10 +101,7 @@ static int ftrace_modify_code_2(unsigned long ip, unsigned int new_code1, return -EFAULT; ip -= 4; - old_fs = get_fs(); - set_fs(KERNEL_DS); flush_icache_range(ip, ip + 8); - set_fs(old_fs); return 0; } @@ -114,7 +110,6 @@ static int ftrace_modify_code_2r(unsigned long ip, unsigned int new_code1, unsigned int new_code2) { int faulted; - mm_segment_t old_fs; ip += 4; safe_store_code(new_code2, ip, faulted); @@ -126,10 +121,7 @@ static int ftrace_modify_code_2r(unsigned long ip, unsigned int new_code1, if (unlikely(faulted)) return -EFAULT; - old_fs = get_fs(); - set_fs(KERNEL_DS); flush_icache_range(ip, ip + 8); - set_fs(old_fs); return 0; } -- 2.29.2