Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp725351pxf; Thu, 1 Apr 2021 11:53:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBsL+HJA8OayQCg1aD0bk8F4JbxdcHSDnyDPql1bydga7shpnWCGkAShEotREpLF57FlB5 X-Received: by 2002:a6b:b7cd:: with SMTP id h196mr7645900iof.59.1617303213772; Thu, 01 Apr 2021 11:53:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617303213; cv=none; d=google.com; s=arc-20160816; b=lTuSEF6MvtlBoAa6dOpMGVqUChj84+6MM3CxXijWC00NTUdbXjJ4excUEsPGuHKUVg Fq7zjIsfgEdFW/HsESl4MdWsRw+0U2rPqUYZ698D5NeS0gIphZ32Pyga/AerBsCn3jbK 5C8QnHoo1kJteylYURQxkdsMF/GrqVYAvIUSo/4wsALYenq807dmzTNK3UBjXXXEJ7Qa wSL4x6ql1x+iZJ956zsFeJ/8AXdCl1mCTpEBBdAevhG90VsuzVpEuaAOO+eex3BQAC56 L4kwp7jJFxpE97s0yhAwgapPY0tCiOFMl4ICeM11sclqaZuJttLYkszEeOeePHSSHzcr FkBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:to:subject:ironport-sdr:ironport-sdr; bh=55BxVoXJ1BUBpY4Noo7FCNfZb7840bUmHy3o8scZOJE=; b=TcJdCU/Ta3tYzSNqPiasVhjkll7yhU/ve4gfQ4ogOEJBd3gvw5hEJZUcE40V9lrAeY 8cdwXnZhdqABG4jPRltvkRYBgwRGOqMkGhiS3xG3RVwYEFRbs6uAw7YnNUAEv8rzDU1O u2+bWNGG70x4JkOWXFy0Oembu51NvXD2l/e0Vgu/uDVJHxaY7oVOnjleNeJlZdPIrDo8 EN4jiS8xu/wnWKYTv3IMtD/n6AjgCuvDIZDsT1jjSaE147FKpxeXJKpTzhwKtGNjj+QT jwzemBlsE5okjASw0qeEgVtbQqUPKW5et5ci09aVgP/M0VkckFQkytjAhA1bwCSs9DGT HIxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e17si5839671iof.24.2021.04.01.11.53.20; Thu, 01 Apr 2021 11:53:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237667AbhDASwp (ORCPT + 99 others); Thu, 1 Apr 2021 14:52:45 -0400 Received: from mga07.intel.com ([134.134.136.100]:4759 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239215AbhDASkF (ORCPT ); Thu, 1 Apr 2021 14:40:05 -0400 IronPort-SDR: kGV+xrUfzUcRU90RmrdOurEym6yVXlsqiPPviIJFOq+OU1buPeQ6KYYFPJuoJCm9sJ8uCihQuZ ghmvOqhtNMhQ== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="256291142" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="256291142" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 11:40:05 -0700 IronPort-SDR: eWJiAyfh1NywKgKGQy4LN84mDTgDltrSsyqUzMOQRtWXWhguJHFj/WfnYXRaETLkn2up+Tx6Ja ubRtN+B4wHMg== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="611024852" Received: from pzlai-mobl.amr.corp.intel.com (HELO [10.213.169.242]) ([10.213.169.242]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 11:40:04 -0700 Subject: Re: [PATCH RESEND 0/3] x86/sgx: eextend ioctl To: Raoul Strackx , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org References: <9688abee-6ba7-e1d9-701e-a5cabac36269@fortanix.com> <0498080e-6fdc-ed6d-8efa-d9c3265fe7e5@intel.com> <9d15aae0-078a-ed72-6c14-155cd1bf27c5@fortanix.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <247ffbee-0ef6-1b6f-75aa-2dc06df42d5d@intel.com> Date: Thu, 1 Apr 2021 11:40:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <9d15aae0-078a-ed72-6c14-155cd1bf27c5@fortanix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/1/21 10:49 AM, Raoul Strackx wrote: > On 4/1/21 6:11 PM, Dave Hansen wrote: >> On 4/1/21 7:56 AM, Raoul Strackx wrote: >>> SOLUTION OF THIS PATCH >>> This patch adds a new ioctl to enable userspace to execute EEXTEND leaf >>> functions per 256 bytes of enclave memory. This enables enclaves to be >>> build as specified by enclave providers. >> I think tying the user ABI to the SGX architecture this closely is a >> mistake. >> >> Do we need another ioctl() or can we just relax the existing add_pages >> ioctl() to allow unaligned addresses? >> > I've considered this. In order to do an EEXTEND without an EADD, we'd > need to add a flag DONT_ADD_PAGES flag to `add_pages` ioctl as well. Two > separate ioctls, one for adding, another for extending made more sense > to me. So, we're talking here about pages that have been EEADDED, but for which we do not want to include the entire contents of the page? Do these contents always include the beginning of the page, or can the holes be anywhere?