Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210401154343.41527-1-dmugil2000@gmail.com>
In-Reply-To: <20210401154343.41527-1-dmugil2000@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 1 Apr 2021 21:05:58 +0300
Message-ID: <CAHp75VfkCQpfUrVcWHUnD4DLMp9iZJBL8mYfsYOCsESm_y068A@mail.gmail.com>
Subject: Re: [PATCH] iio: adc: stm32-dfsdm: drop __func__ while using Dynamic debug
To:     Mugilraj Dhavachelvan <dmugil2000@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        linux-iio <linux-iio@vger.kernel.org>,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Apr 1, 2021 at 8:48 PM Mugilraj Dhavachelvan
<dmugil2000@gmail.com> wrote:
>
> dropped __func__ while using dev_dbg() and pr_debug()

The commit message may be amended, from code perspective LGTM!
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Mugilraj Dhavachelvan <dmugil2000@gmail.com>
> ---
>  drivers/iio/adc/stm32-dfsdm-adc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index 76a60d93fe23..95ec5f3c3126 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -198,7 +198,7 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
>         unsigned int p = fl->ford;      /* filter order (ford) */
>         struct stm32_dfsdm_filter_osr *flo = &fl->flo[fast];
>
> -       pr_debug("%s: Requested oversampling: %d\n",  __func__, oversamp);
> +       pr_debug("Requested oversampling: %d\n", oversamp);
>         /*
>          * This function tries to compute filter oversampling and integrator
>          * oversampling, base on oversampling ratio requested by user.
> @@ -294,8 +294,8 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
>                                 }
>                                 flo->max = (s32)max;
>
> -                               pr_debug("%s: fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
> -                                        __func__, fast, flo->fosr, flo->iosr,
> +                               pr_debug("fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
> +                                        fast, flo->fosr, flo->iosr,
>                                          flo->res, bits, flo->rshift,
>                                          flo->lshift);
>                         }
> @@ -858,7 +858,7 @@ static void stm32_dfsdm_dma_buffer_done(void *data)
>          * support in IIO.
>          */
>
> -       dev_dbg(&indio_dev->dev, "%s: pos = %d, available = %d\n", __func__,
> +       dev_dbg(&indio_dev->dev, "pos = %d, available = %d\n",
>                 adc->bufi, available);
>         old_pos = adc->bufi;
>
> @@ -912,7 +912,7 @@ static int stm32_dfsdm_adc_dma_start(struct iio_dev *indio_dev)
>         if (!adc->dma_chan)
>                 return -EINVAL;
>
> -       dev_dbg(&indio_dev->dev, "%s size=%d watermark=%d\n", __func__,
> +       dev_dbg(&indio_dev->dev, "size=%d watermark=%d\n",
>                 adc->buf_sz, adc->buf_sz / 2);
>
>         if (adc->nconv == 1 && !indio_dev->trig)
> --
> 2.25.1
>


-- 
With Best Regards,
Andy Shevchenko