Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 1 Apr 2021 22:41:13 +0200
From:   Frederic Weisbecker <frederic@kernel.org>
To:     "Paul E. McKenney" <paulmck@kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] torture: Correctly fetch CPUs for kvm-build.sh with all
 native language
Message-ID: <20210401204113.GB116405@lothringen>
References: <20210401132602.116352-1-frederic@kernel.org>
 <20210401185116.GH2696@paulmck-ThinkPad-P72>
 <20210401203112.GA116405@lothringen>
 <20210401204022.GI2696@paulmck-ThinkPad-P72>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210401204022.GI2696@paulmck-ThinkPad-P72>
Precedence: bulk

On Thu, Apr 01, 2021 at 01:40:22PM -0700, Paul E. McKenney wrote:
> On Thu, Apr 01, 2021 at 10:31:12PM +0200, Frederic Weisbecker wrote:
> > On Thu, Apr 01, 2021 at 11:51:16AM -0700, Paul E. McKenney wrote:
> > > On Thu, Apr 01, 2021 at 03:26:02PM +0200, Frederic Weisbecker wrote:
> > > > Grepping for "CPU" on lscpu output isn't always successful, depending
> > > > on the local language setting. As a result, the build can be aborted
> > > > early with:
> > > > 
> > > > 	"make: the '-j' option requires a positive integer argument"
> > > > 
> > > > Prefer a more generic solution.
> > > > 
> > > > Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> > > 
> > > Good catch, applied, thank you!
> > > 
> > > There is a similar construct in kvm-remote.sh, so I added a similar
> > > fix to your patch.
> > > 
> > > But what about this in functions.sh?
> > > 
> > > nt="`lscpu | grep '^NUMA node0' | sed -e 's/^[^,]*,\([0-9]*\),.*$/\1/'`"
> > > 
> > > I am guessing that "node0" is human-language-independent, but is "NUMA"?
> > 
> > I thought they wouldn't bother translating that, but they did...
> > 
> >     NUMA node0 CPU(s):               0-7
> > 
> > becomes:
> > 
> >     Nœud NUMA 0 de processeur(s) : 0-7
> > 
> > Not sure about the best way to fix it.
> 
> The rude and crude fix is for the scripts to force the local language
> to English.  ;-)

I don't have a better answer :o)