Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201024004706.24518-1-linux@rasmusvillemoes.dk> <d09f16d8-528e-2815-8f26-ab85c27b1fea@gmail.com>
In-Reply-To: <d09f16d8-528e-2815-8f26-ab85c27b1fea@gmail.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 1 Apr 2021 17:15:29 -0400
Message-ID: <CADnq5_PLZoz0Ns0i8ur2i6YY1H==g+WRvFJZ6K3EDDvd9Qfmyw@mail.gmail.com>
Subject: Re: [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <ckoenig.leichtzumerken@gmail.com>
Cc:     Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Alex Deucher <alexander.deucher@amd.com>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Current code already contains the fix.

Alex


On Thu, Apr 1, 2021 at 9:09 AM Christian K=C3=B6nig
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Am 24.10.20 um 02:47 schrieb Rasmus Villemoes:
> > Keep sparse happy by preserving the __user annotation when casting.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>
> Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com>
>
> Going over old patches and stumbled over that once.
>
> Alex did you missed to pick it up?
>
> Regards,
> Christian.
>
> > ---
> >
> > kernel test robot has already started spamming me due to 9c5743dff. If
> > I don't fix those warnings I'll keep getting those emails for
> > months, so let me do the easy ones.
> >
> >
> >   drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/rade=
on/radeon_ttm.c
> > index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
> > --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> > @@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *=
f, char __user *buf,
> >               value =3D RREG32(RADEON_MM_DATA);
> >               spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);
> >
> > -             r =3D put_user(value, (uint32_t *)buf);
> > +             r =3D put_user(value, (uint32_t __user *)buf);
> >               if (r)
> >                       return r;
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx