Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 9RNyp/CswwWPJnfFyhvYgU3NO+Gi4K4TRHipOhRXAS/qQOeV5W3kDGaIt3CxZBCr4xA0vO1ciE
 lwJuiMqxs9iw==
IronPort-SDR: PhA53mSmCRZ1TXk7sv3w0JZVBESPPWVEmpjzLamuolrdoeFG0mcDUbQHVpx7udqHSRXMwNgGxr
 UnKJlIWkQZhA==
Subject: Re: [RFC v1 03/26] x86/cpufeatures: Add is_tdx_guest() interface
To:     Dave Hansen <dave.hansen@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>
Cc:     Andi Kleen <ak@linux.intel.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Raj Ashok <ashok.raj@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        linux-kernel@vger.kernel.org,
        Sean Christopherson <sean.j.christopherson@intel.com>
References: <cover.1612563142.git.sathyanarayanan.kuppuswamy@linux.intel.com>
 <83c8fcff9ac09f73924104cfb534258747e98bff.1612563142.git.sathyanarayanan.kuppuswamy@linux.intel.com>
 <0116481d-581b-9433-3641-47e39550b99a@intel.com>
From:   "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
Message-ID: <8f0bd4e5-195b-7e65-f780-f5e31d72cfe8@linux.intel.com>
Date:   Thu, 1 Apr 2021 14:15:52 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <0116481d-581b-9433-3641-47e39550b99a@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/1/21 2:08 PM, Dave Hansen wrote:
> On 2/5/21 3:38 PM, Kuppuswamy Sathyanarayanan wrote:
>> +bool is_tdx_guest(void)
>> +{
>> +	return static_cpu_has(X86_FEATURE_TDX_GUEST);
>> +}
> 
> Why do you need is_tdx_guest() as opposed to calling
> cpu_feature_enabled(X86_FEATURE_TDX_GUEST) everywhere?

is_tdx_guest() is also implemented/used in compressed
code (which uses native_cpuid calls). I don't think
we can use cpu_feature_enabled(X86_FEATURE_TDX_GUEST) in
compressed code right? Also is_tdx_guest() looks easy
to read and use.
> 

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer