Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp809556pxf; Thu, 1 Apr 2021 14:17:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuZDCXS7DqPlaESBh4ORnSsvV9LkarhJoZatZnC+VU0bEzXVtVgLJe5YRa8E0VzZchr5Cs X-Received: by 2002:a17:906:c9d8:: with SMTP id hk24mr11316237ejb.480.1617311832205; Thu, 01 Apr 2021 14:17:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617311832; cv=none; d=google.com; s=arc-20160816; b=Zho8Fq6Ko0JYmeC5uNTwhRRE88luQ7nfXRCvQpwV39xDiDfWzDJ+hJC0u7BA2izG7f 9S6EUws4eUzGyEry9/FMGBlgwia62xwuHd+/xSHMRxo/4n5Ww4uOoXUPTG2dMi52X2Y7 KUz5flSmnzQBhxSp7cvCBo4v4MBtW5BaQiutOehQ7thvN00obUs6huHeZv8nAhRygYti YuOygpmYUC7QfeNaPAOGp3YIkLz02x0Ts6ZSQDPzHGrsy+9KfGGm7JARiMUtbSZKlt8a VtS5Vg6ucjx9zIaGJXqlaPxXslYxNdb6nq4aBhDsOYTTkuyJIXQAcryKAxU43jIEAK6J WQ3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AbomE8ky01qR1Z9SBdGuAWnmdVOm7eL8+7fxREb+Hlc=; b=hJjhfggW3NMTeqpkyM1Z7G7Sk8E9Y2q57C5yYbOioD0PRjnptmWNCTqa9rftMfreEc kUfCENF0i5h7J7ZGdW3qXPSbv5AfsCiDtlR39fmw8aYAwYGgmJwMhZXEcsfTIoZ38qZQ 76bHFWh/5EbdL5OXQzlq8MNrBHiUmBBNkVJEYSBSkf5WhiUm2IAJcprBTXT4rZTZ5a2r znv1wIRIwW5IKXb0V7jaoysmI2Srvo2GmNMjFLAl8aaMTvjMEunPeiLf/lRV4p0BSWEq AhM/vnKtVEGe/4y8F7QrqyQ6EEk4jGtGwrRi8st8n60UmzysmWE3OE+43fRy/1YOg6Q3 4fAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=enGK1gWT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s6si4892128ejq.79.2021.04.01.14.16.48; Thu, 01 Apr 2021 14:17:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=enGK1gWT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234201AbhDAVOO (ORCPT + 99 others); Thu, 1 Apr 2021 17:14:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233710AbhDAVON (ORCPT ); Thu, 1 Apr 2021 17:14:13 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC742C061788 for ; Thu, 1 Apr 2021 14:14:10 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id bt4so1788495pjb.5 for ; Thu, 01 Apr 2021 14:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AbomE8ky01qR1Z9SBdGuAWnmdVOm7eL8+7fxREb+Hlc=; b=enGK1gWTmqo4sAFtbviKEU1c5trz7yPEAkvErUrGPfI4DPYCNFXKC6IN9cJQe34kP8 kg/pFklYyLZmOx3F/Qejag4gScfEwSzUjq259VRfJOQcYd8fCbHSkUZqmTNNRrpssQXK +n4xOpP/rsmMY7TFbzrNgmCUfmMoO+kkUKJ4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AbomE8ky01qR1Z9SBdGuAWnmdVOm7eL8+7fxREb+Hlc=; b=GTYnj6xR1d1KRsVpdNmR0IEwz79FP+6PdPvBn36/mD+sTGQ6VPIjBcJ1Cy0+3gmmQv QtN2J2qSYuBRqt9RPh+IGiATUL5SGGk0DTZDiJay4342cCuY3iD3ywLzlvtd6U/SrdFw eDDFuGGrA6zxH/2fqBuZoRuVYsj3gk1TqA82TsQqPouIC4sPVEbclQ5tj1YsMU889xy8 dG15f/gHIlDWxbqn3UrgEh/32RGYLiLOwngjT0rVv4+0/hPC5tjPw9/xujMHatwpSfnY jBMA3/rBKfH7ddOa9tjS40sYzL6iSJSxx5qrm+ksqVK+Rj7lJkFwPcsP/JCQdwoITvMV ZZUQ== X-Gm-Message-State: AOAM531AgSOLHbbBRFU6ahyZ6E+ra+Y0aMhAxZP4yfcRLrCT9AqD3lxr y5tFxfVq2HeyfNDJFVjVF9NkvLcyMYkX7g== X-Received: by 2002:a17:90a:6708:: with SMTP id n8mr11098340pjj.174.1617311650543; Thu, 01 Apr 2021 14:14:10 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x4sm5952907pfn.134.2021.04.01.14.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Apr 2021 14:14:09 -0700 (PDT) From: Kees Cook To: Keith Busch , linux-kernel@vger.kernel.org Cc: Kees Cook , Jason Gunthorpe Subject: Re: [PATCH] overflow: improve check_shl_overflow comment Date: Thu, 1 Apr 2021 14:13:24 -0700 Message-Id: <161731160130.2687418.11028495096127465037.b4-ty@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210401160629.1941787-1-kbusch@kernel.org> References: <20210401160629.1941787-1-kbusch@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Apr 2021 09:06:29 -0700, Keith Busch wrote: > A 'false' return means the value was safely set, so the comment should > say 'true' for when it is not considered safe. Oops, yes; too many inverse negatives. ;) Applied to for-next/overflow, thanks! [1/1] overflow: Correct check_shl_overflow() comment https://git.kernel.org/kees/c/4578be130a64 -- Kees Cook