Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030643AbWJJXUR (ORCPT ); Tue, 10 Oct 2006 19:20:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030335AbWJJXUQ (ORCPT ); Tue, 10 Oct 2006 19:20:16 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:62860 "EHLO e36.co.us.ibm.com") by vger.kernel.org with ESMTP id S1030333AbWJJXUO (ORCPT ); Tue, 10 Oct 2006 19:20:14 -0400 Message-ID: <452C2AAA.5070001@austin.ibm.com> Date: Tue, 10 Oct 2006 18:20:10 -0500 From: jschopp User-Agent: Thunderbird 1.5.0.7 (X11/20060909) MIME-Version: 1.0 To: Linas Vepstas CC: akpm@osdl.org, jeff@garzik.org, Arnd Bergmann , netdev@vger.kernel.org, James K Lewis , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH 21/21]: powerpc/cell spidernet DMA coalescing References: <20061010204946.GW4381@austin.ibm.com> <20061010212324.GR4381@austin.ibm.com> In-Reply-To: <20061010212324.GR4381@austin.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 17 Linas Vepstas wrote: > The current driver code performs 512 DMA mappns of a bunch of > 32-byte structures. This is silly, as they are all in contiguous > memory. Ths patch changes the code to DMA map the entie area > with just one call. > > Signed-off-by: Linas Vepstas > Cc: James K Lewis > Cc: Arnd Bergmann The others look good, but this one complicates the code and doesn't have any benefit. 20 for 21 isn't bad. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/