Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210401131012.395311786@infradead.org> <20210401133917.469929784@infradead.org>
In-Reply-To: <20210401133917.469929784@infradead.org>
From:   Josh Don <joshdon@google.com>
Date:   Thu, 1 Apr 2021 17:34:13 -0700
Message-ID: <CABk29NuhhwPgFm9HQs=CgpPMKAiqVn4kOACwwEeTYmBTbw03Uw@mail.gmail.com>
Subject: Re: [PATCH 7/9] sched: Cgroup core-scheduling interface
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Joel Fernandes <joel@joelfernandes.org>,
        "Hyser,Chris" <chris.hyser@oracle.com>,
        Ingo Molnar <mingo@kernel.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Valentin Schneider <valentin.schneider@arm.com>,
        Mel Gorman <mgorman@suse.de>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Tejun Heo <tj@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Thanks, allowing for multiple group cookies in a hierarchy is a nice
improvement.

> +               if (tgi != tg) {
> +                       if (tgi->core_cookie || (tgi->core_parent && tgi->core_parent != tg))
> +                               continue;
> +
> +                       tgi->core_parent = parent;
> +                       tgi->core_cookie = 0;

core_cookie must already be 0, given the check above.