Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: JG87bHAPFM6IvOklwvrKa5JUOhDTbkbzg/UjcIJRJdqcYHbo0HeE9kRPCuUXHdWcTl+8G0Iq4x
 2aX1on7J0tpddSSP/oPEp1inlQDtttbGHsdFUzO96k3ydiUs/NXhJuAs21GhlrYLpW+chy1ak3
 KjNRJyhP+TLn9/Y+lMosIjURsprIfW1rFTAvE5QOuv/KDltEUNHLJNzm6GIz80+hs4S8UdzBHS
 N5xee6D3/2TvQ9ZyN7KbOFGGAPjckhWXGeS56gkaiFtjwVvHwiOCpB6f45K71HetGxcAS8aU59
 nVU=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     "adrian.hunter@intel.com" <adrian.hunter@intel.com>
CC:     Avri Altman <Avri.Altman@wdc.com>,
        "bpeter@lytx.com" <bpeter@lytx.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Subject: Re: [PATCH 1/2] mmc: block: Issue flush only if allowed
Thread-Topic: Re: [PATCH 1/2] mmc: block: Issue flush only if allowed
Thread-Index: Adcnk8DrfYl5cGeLTJWc5CWz12wyzA==
Date:   Fri, 2 Apr 2021 07:46:51 +0000
Message-ID: <DM6PR04MB6575658643D2344B4AE027C8FC7A9@DM6PR04MB6575.namprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 47c23beb-af9c-4f0b-b0a6-08d8f5ab7a9b
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2021 07:46:51.5204
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: C4hMP82XrlmaylOVEw/3UapkRD4fPPxd+d43m+bfQFonempAj3F/8tkFmRAs9IRtg2A0naUtSiiCHfh064MV2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB5626
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -1473,6 +1473,9 @@ static int mmc_blk_cqe_issue_flush(struct mmc_queu=
e *mq, struct request *req)
>>  	struct mmc_queue_req *mqrq =3D req_to_mmc_queue_req(req);
>>  	struct mmc_request *mrq =3D mmc_blk_cqe_prep_dcmd(mqrq, req);
>> =20
>> +	if (mmc_card_mmc(mq->card) && !mmc_flush_allowed(mq->card))
>> +		return 0;

> Returning 0 means the flush was issued successfully. i.e. it is in
> flight.
>
> Instead, a call to blk_mq_end_request(req, BLK_STS_OK) is needed,
> and mmc_blk_mq_issue_rq() must be amended so that it will return
> MMC_REQ_DONE for this case.
Done.

Thanks,
Avri