Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1101220pxf; Fri, 2 Apr 2021 00:54:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFKZDgYvGpwYoY8ee6+SMIetDI0p3Fx1JeFQ+RyVmV6sX0pbZT/rb9ENjWxd9aFLDk2RTG X-Received: by 2002:a5d:9149:: with SMTP id y9mr9857608ioq.159.1617350093627; Fri, 02 Apr 2021 00:54:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617350093; cv=none; d=google.com; s=arc-20160816; b=Pg9sq8dkMYSeXCdIYqLJ83qh8tvk53SeCQp3PlNtCb+TMuDEuvfP/WTTSOFb/SGOKT 18WJUWGkUFSHJaPczjKyqwxpSGgGlf57OlFFjdBUM+EnXGwECltmhaI6TBd16SIStKFy dU4AA8wQQSWMtonn6OT5M9GAvs7MjL4IjylwPUxeXYS3DLfCslSavVQVDh9EeQ+a67LR TNpqJ1/RQcbYBRLfoHLyQ9drgEWQHnJ64ojlkIml4ZzPha2jO8zQjhNnxzzB4p2YItCX Cou/Qt+a0AbIiLfixxT/ED0jzZs+2412v5hc6MisByFQyF7LIAj8PSfukaxD4S4YUmO0 nRMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8Fu7OPI4lOy0doR/jgfxXQKQoXXwhu+8ywiYbWVJktQ=; b=N2SE1z00YOgHWNTnNSqLJEDgVdHzgVYotGE8/DUT7d8Kq7CDZKW1RJTIt+6Fk7NCAw oiVfak73owz3/l9EPC7bwoAsV/Pzr95LYkj/Mi0ixx2KASI7tLm0OXOM6vWgGLc27QsK APs9cyW/tMldCX216h5dTSpcYPzHTR+L1Mq8WTH/fn+S52TkkyrfgYDy9XQJ8w0V/DTs IQPWhOBhT/MdJAvlsW7UQ8bKX20hhxLJOuV+0umBblRXOTdpimnqJ0dkBPydJGsHngRn 4u2FJVf/UmkHpfVcLAZ0G6fMOZZriBGYsupHwmWsYs6Jhi6LpwNxoAUtxI1XyMDcf7ZV gRwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ux+hbwzM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o7si8317940ilt.153.2021.04.02.00.54.39; Fri, 02 Apr 2021 00:54:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ux+hbwzM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234361AbhDBHyR (ORCPT + 99 others); Fri, 2 Apr 2021 03:54:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:34096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234217AbhDBHyQ (ORCPT ); Fri, 2 Apr 2021 03:54:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DAE4061103; Fri, 2 Apr 2021 07:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617350055; bh=rgAN5tZmvrtw+l6Z9MPiySclNGXhZ1o2U2MSPQYWr3g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ux+hbwzMDDMPpgMKWAK/ZdqlMjwjDKCk3k4nHlq7/vmtiMNbA39NNQiftujSoK6da ixoeeWGlZeFt20Ed1CpxsayE5/GIzcq0iYnn5bTASWKA4XMF366eKIcMHapf1aGU9I 002pWXurMeElpLaGHfYm1awf4b5JpcVR10+TDcuI= Date: Fri, 2 Apr 2021 09:54:12 +0200 From: Greg KH To: Luis Chamberlain Cc: Minchan Kim , keescook@chromium.org, dhowells@redhat.com, hch@infradead.org, mbenes@suse.com, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate Message-ID: References: <20210310212128.GR4332@42.do-not-panic.com> <20210312183238.GW4332@42.do-not-panic.com> <20210319190924.GK4332@42.do-not-panic.com> <20210322204156.GM4332@42.do-not-panic.com> <20210401235925.GR4332@42.do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210401235925.GR4332@42.do-not-panic.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 01, 2021 at 11:59:25PM +0000, Luis Chamberlain wrote: > As for the syfs deadlock possible with drivers, this fixes it in a generic way: > > commit fac43d8025727a74f80a183cc5eb74ed902a5d14 > Author: Luis Chamberlain > Date: Sat Mar 27 14:58:15 2021 +0000 > > sysfs: add optional module_owner to attribute > > This is needed as otherwise the owner of the attribute > or group read/store might have a shared lock used on driver removal, > and deadlock if we race with driver removal. > > Signed-off-by: Luis Chamberlain No, please no. Module removal is a "best effort", if the system dies when it happens, that's on you. I am not willing to expend extra energy and maintance of core things like sysfs for stuff like this that does not matter in any system other than a developer's box. Lock data, not code please. Trying to tie data structure's lifespans to the lifespan of code is a tangled mess, and one that I do not want to add to in any form. sorry, greg k-h