Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 2/2] iio: temperature: add driver support for ti tmp117
To:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Puranjay Mohan <puranjay12@gmail.com>
Cc:     Alexandru Ardelean <alexandru.ardelean@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20210401091648.87421-1-puranjay12@gmail.com>
 <20210401091648.87421-3-puranjay12@gmail.com>
 <CAHp75Vcmyvi4V2D0cnmobTGHCS_ci2FC=cBF8tEoG9v51o8RmQ@mail.gmail.com>
From:   Lars-Peter Clausen <lars@metafoo.de>
Message-ID: <0d2bce88-1c23-a711-6a37-118173066ab5@metafoo.de>
Date:   Fri, 2 Apr 2021 10:14:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <CAHp75Vcmyvi4V2D0cnmobTGHCS_ci2FC=cBF8tEoG9v51o8RmQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 4/1/21 11:36 AM, Andy Shevchenko wrote:
> [...]
>> +       case IIO_CHAN_INFO_SCALE:
>> +               /* Conversion from 10s of uC to mC
>> +                * as IIO reports temperature in mC
>> +                */
>> +               *val = TMP117_RESOLUTION_10UC / 10000;
>> +               *val2 = (TMP117_RESOLUTION_10UC % 10000) * 100;
>> +               return IIO_VAL_INT_PLUS_MICRO;
> You use 10000 many times, can you give it an appropriate name (via #define)?
#define TENTHOUSAND 10000 ;)