Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 1 Apr 2021 09:02:04 -0500
From:   Benoit Parrot <bparrot@ti.com>
To:     Yang Yingliang <yangyingliang@huawei.com>
CC:     <linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
        <mchehab@kernel.org>
Subject: Re: [PATCH -next] media: ti-vpe: sc: remove redundant dev_err call
 in sc_create()
Message-ID: <20210401140204.bikghitzypf7fraf@ti.com>
References: <20210401103015.1555941-1-yangyingliang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20210401103015.1555941-1-yangyingliang@huawei.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

Yang,

Thank you for the patch.

Yang Yingliang <yangyingliang@huawei.com> wrote on Thu [2021-Apr-01 18:30:15 +0800]:
> There is an error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/media/platform/ti-vpe/sc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/ti-vpe/sc.c b/drivers/media/platform/ti-vpe/sc.c
> index 98f95082a6fd..0202d278523f 100644
> --- a/drivers/media/platform/ti-vpe/sc.c
> +++ b/drivers/media/platform/ti-vpe/sc.c
> @@ -294,10 +294,8 @@ struct sc_data *sc_create(struct platform_device *pdev, const char *res_name)
>  	}
>  
>  	sc->base = devm_ioremap_resource(&pdev->dev, sc->res);
> -	if (IS_ERR(sc->base)) {
> -		dev_err(&pdev->dev, "failed to ioremap\n");
> +	if (IS_ERR(sc->base))
>  		return ERR_CAST(sc->base);
> -	}

Reviewed-by: Benoit Parrot <bparrot@ti.com>

>  
>  	return sc;
>  }
> -- 
> 2.25.1
>