Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 2 Apr 2021 10:59:25 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Henrik Rydberg <rydberg@bitmath.org>,
        linux-input@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.ne@posteo.net>
Subject: Re: [PATCH v2 3/3] Input: add driver for the Hycon HY46XX touchpanel
 series
Message-ID: <YGbc7Qbu6s659Mx4@latitude>
References: <20210306194120.GA1075725@robh.at.kernel.org>
 <20210401230358.2468618-1-giulio.benetti@benettiengineering.com>
 <20210401230358.2468618-4-giulio.benetti@benettiengineering.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="F4oZXRIuQxOUFdge"
Content-Disposition: inline
In-Reply-To: <20210401230358.2468618-4-giulio.benetti@benettiengineering.com>
Precedence: bulk


--F4oZXRIuQxOUFdge
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

a few remarks below.

On Fri, Apr 02, 2021 at 01:03:58AM +0200, Giulio Benetti wrote:
> This patch adds support for Hycon HY46XX.
>=20
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * removed proximity-sensor-switch property according to previous patch
> As suggested by Dmitry Torokhov
> * moved i2c communaction to regmap use
> * added macro to avoid magic number
> * removed cmd variable that could uninitiliazed since we're using regmap =
now
> * removed useless byte masking
> * removed useless struct hycon_hy46xx_i2c_chip_data
> * used IRQF_ONESHOT only for isr
> ---


> +config TOUCHSCREEN_HYCON_HY46XX
> +	tristate "Hycon hy46xx touchscreen support"
> +	depends on I2C
> +	help
> +	  Say Y here if you have a touchscreen using Hycon hy46xx,
> +	  or something similar enough.

The "something similar enough" part doesn't seem relevant, because the
driver only lists HY46xx chips (in the compatible strings), and no chips
that are similar enough to work with the driver, but have a different
part number.

> +static void hycon_hy46xx_get_defaults(struct device *dev, struct hycon_h=
y46xx_data *tsdata)
> +{
> +	bool val_bool;
> +	int error;
> +	u32 val;
> +
> +	error =3D device_property_read_u32(dev, "threshold", &val);

This seems to follow the old version of the binding, where
Hycon-specific properties didn't have the "hycon," prefix.
Please check that the driver still works with a devicetree that follows
the newest version of the binding.

> +MODULE_AUTHOR("Giulio Benetti <giulio.benetti@micronovasrl.com>");

This is a different email address than you used in the DT binding. If
this is intentional, no problem (Just letting you know, in case it's
unintentional).


Thanks,
Jonathan Neusch=C3=A4fer

--F4oZXRIuQxOUFdge
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmBm3OUACgkQCDBEmo7z
X9upNQ/8DWmEiVnx/iq6BM00GmeRFWSkwuLnvC1jVHjRJPHIhpa8f0SYBg9wbADt
z3AjK4OyxECPBB0mf3tcBq8MO9dRQ7tXc6P4/UhBZqDkprxkZQoKKGogYxWwAmbP
vaoDO6XO+iQ+3huy5Go0s0qWz1TOwX2cNsDM6Wh4ThHcL6OryofS+bqK7H3F8SW5
Ej4OiubMxfQQ75ep6HNiDQpOZY8xFMxwsLh7nl6E1kGR93Q2lWy2FllgHQdx9tmY
cJNzFFuFU2yZYCUsuDC/2/EOIV44Lrxe2/C5O+FQqJYo8fUrjB/CkmUadHjKpcJG
R7NFuwl1SH1qf+yox9Pxgd4DFkR0fTNNCjkZU0efBA4cyq/V9QVdqFilImIYkTAD
8jSjgJHGBBRxISz2QsAYMiWs2OU/CsEoX7e9S3uxy/XuIp6a+1yUwtAeZAlcfkX7
+Qc8uVHTkzw+isi3xojy7YCs8+x1I62oQWsN9j9r+TMt6souLc5jPiFHUHk+g4Yo
S1HiHk0Jn5q9yIR2QblDK5kBJw4W2aNTcnMrmCh5lODk9LC6+qnisyDvX+B/PKVZ
Qfol/vuaO1to+waAiigNua4egVpDcj7EO7jW74W5z+4rTV5iVF7X8E+pgd3XrVm2
EJGGT7W41TFH0ueu/v2x7KN1p4Iq1VHO/DTqd/ho0Cv0IQooZIs=
=yZTH
-----END PGP SIGNATURE-----

--F4oZXRIuQxOUFdge--