Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1162817pxf; Fri, 2 Apr 2021 03:03:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3DFyW8vRlbSvKxn874JdkQvoxYFIlJQpj/4ssduBndKzCNTfaq0cmrXV28HZh8O+0rNaS X-Received: by 2002:a17:907:20f5:: with SMTP id rh21mr13802274ejb.27.1617357780680; Fri, 02 Apr 2021 03:03:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617357780; cv=none; d=google.com; s=arc-20160816; b=B4nEaWYGbg6Y+Yb0BkN66tQ2Cbw86ZzDyEa5mzp/WseGcfFjDBxoBklJmFpR294my9 Fr5+d/zGk/q2R/+psOcrqaxmjUtW4lwON/jZ3FQpjT54KKZwxQxSSaXUaCQFEaZhgtKq dhMyIQD5EbDlHvj7a0PcQ7fItYqQKicVMDH/uLZychtess5xqRhfDA5o1O9KA4FZ54a1 +CRF1I4T/0lHbEX8iFUPmF5aZAh1xF7QnHappT2CVpwAQkGsxFYATNDrj6cAcO0pSVtp S2wc5Wr+PaA6rLUi7U9oxCK+lrZAoXxYtSBy7w0vh5exArVDUcB6NdDIzT9ASSJDba9c Pt6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=elDtaXxqbBz7CfvdseF55dVdfqtzeGsUAApAih4pNfs=; b=LzuzPVmqMvbJYxti2BW9waLofLk0grMGu7j0pYpjiS0Pxfo4e6Dr0Bz8bxLGdj0QNN dD+XcLPT1rD2bus1a14kZyGNnitHBiRR5Kz7SFPQ7Dt7Ie0S2GsFEnDYz/EYu4ySh/02 u9sTcTlsV5Q0Cbj8EHiU4aclOzY6umjD8mKncW3B/VS4C6+HePHytt+i25IePClnFcYt Iy5vmW/I/1aGwN3BKv0a5DQH35l5vMSbYeHpdnoSO0Gseg84EOJrcCujRGCsGClSEcq9 w8aX9K+iDC/yNbaTh+1NnlF24aswLLF15sDHFinpy+ah174Cc2H8usDY/8tZvsmzAlCV vFFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ftd6A96T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v21si6906430ejg.244.2021.04.02.03.02.31; Fri, 02 Apr 2021 03:03:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ftd6A96T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234666AbhDBKB4 (ORCPT + 99 others); Fri, 2 Apr 2021 06:01:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234548AbhDBKBx (ORCPT ); Fri, 2 Apr 2021 06:01:53 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ABBDC0613E6 for ; Fri, 2 Apr 2021 03:01:52 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id x21so4959025eds.4 for ; Fri, 02 Apr 2021 03:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=elDtaXxqbBz7CfvdseF55dVdfqtzeGsUAApAih4pNfs=; b=ftd6A96TpJuaxPHFNifHwgr3lhJgmLSmAwt7+SMzZWikWuTE+XRo7UyGWJlQwSWXXI EbfPgzA+kmb/+5dj95qoZ4pgdD7alHALrMKU5kX/N1R6R6iILUO+FwYbMlRtpbJAAfLO G4j0aqMHrAYYaHpd1nSOHLvTSq6Rtlf5YAfHFSc4M79sOuRUMdtnian9U0nfaKcZQJ1n dneIrAtkgqKspn612j0YOjBO6nehWlBU6RNZ/80NHnAcNju9wcARwkZ9gjFmZCjAwPKO s65rC8jr2CURc5FzjFIzgBUtkrp23xbFrkjHWVHipIKaIyAqJiw7AMeqrkHfX3fkP0dl heUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=elDtaXxqbBz7CfvdseF55dVdfqtzeGsUAApAih4pNfs=; b=iYJwR6epA7LfCA/dQkJ56WXR2eTu8grTeM20voT9xkY7nKAbTpAc5TDX9WMyL0DFts /4TenPBkEsntBEqouaYI5HnFhIARf9hnqZqgbAnAEuhQ41IIIAo5yAKDJ+So2fYTh7GI S12Uc0/uo+557acpCuwbHtLAC+DvAih4qEnBqu4nXGIQP+iUXlI4f2TmGNAUmvEAGGk4 VYVuwZn+Dchze8C6zfd8RL5Wo0NiAx/Y2uTdliDcF3zVBZTq2ZXgXtU0AMUAaBsVvxFl XgJNMQ+iTkU+QaLq6yPKfVqbAdsKos89S2Aism/FzzQs3qTP+v3VzWBz/QPWolJLuC0E Kmag== X-Gm-Message-State: AOAM5324wBvXpbE9kBiD5N3dXHYsf8T+H6Oyf5dFmYR4xV3HdKPLPwl+ ifGLukAuGUcJbE1GszQNMmw= X-Received: by 2002:aa7:d4d6:: with SMTP id t22mr14947384edr.376.1617357711241; Fri, 02 Apr 2021 03:01:51 -0700 (PDT) Received: from agape ([5.171.72.128]) by smtp.gmail.com with ESMTPSA id r5sm5285533eds.49.2021.04.02.03.01.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 03:01:50 -0700 (PDT) From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: dan.carpenter@oracle.com, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Fabio Aiuto Subject: [PATCH 03/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.c Date: Fri, 2 Apr 2021 12:01:23 +0200 Message-Id: <7f2f51a4b3301bec3f3c5a1523f7de0cb2ff2efe.1617356821.git.fabioaiuto83@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org remove all RT_TRACE logs fix patch-related checkpatch issues Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_eeprom.c | 56 ++++++++------------- 1 file changed, 22 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_eeprom.c b/drivers/staging/rtl8723bs/core/rtw_eeprom.c index 3cbd65dee741..be0eda1604d0 100644 --- a/drivers/staging/rtl8723bs/core/rtw_eeprom.c +++ b/drivers/staging/rtl8723bs/core/rtw_eeprom.c @@ -35,10 +35,9 @@ void shift_out_bits(_adapter *padapter, u16 data, u16 count) u16 x, mask; _func_enter_; - if (padapter->bSurpriseRemoved == true) { - RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true")); + if (padapter->bSurpriseRemoved) goto out; - } + mask = 0x01 << (count - 1); x = rtw_read8(padapter, EE_9346CR); @@ -48,20 +47,18 @@ _func_enter_; x &= ~_EEDI; if (data & mask) x |= _EEDI; - if (padapter->bSurpriseRemoved == true) { - RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true")); - goto out; - } + if (padapter->bSurpriseRemoved) + goto out; + rtw_write8(padapter, EE_9346CR, (u8)x); udelay(CLOCK_RATE); up_clk(padapter, &x); down_clk(padapter, &x); mask = mask >> 1; } while (mask); - if (padapter->bSurpriseRemoved == true) { - RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true")); + if (padapter->bSurpriseRemoved) goto out; - } + x &= ~_EEDI; rtw_write8(padapter, EE_9346CR, (u8)x); out: @@ -72,10 +69,9 @@ u16 shift_in_bits(_adapter *padapter) { u16 x, d = 0, i; _func_enter_; - if (padapter->bSurpriseRemoved == true) { - RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true")); + if (padapter->bSurpriseRemoved) goto out; - } + x = rtw_read8(padapter, EE_9346CR); x &= ~(_EEDO | _EEDI); @@ -84,10 +80,9 @@ _func_enter_; for (i = 0; i < 16; i++) { d = d << 1; up_clk(padapter, &x); - if (padapter->bSurpriseRemoved == true) { - RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true")); + if (padapter->bSurpriseRemoved) goto out; - } + x = rtw_read8(padapter, EE_9346CR); x &= ~(_EEDI); @@ -122,26 +117,22 @@ void eeprom_clean(_adapter *padapter) { u16 x; _func_enter_; - if (padapter->bSurpriseRemoved == true) { - RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true")); + if (padapter->bSurpriseRemoved) goto out; - } + x = rtw_read8(padapter, EE_9346CR); - if (padapter->bSurpriseRemoved == true) { - RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true")); + if (padapter->bSurpriseRemoved) goto out; - } + x &= ~(_EECS | _EEDI); rtw_write8(padapter, EE_9346CR, (u8)x); - if (padapter->bSurpriseRemoved == true) { - RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true")); + if (padapter->bSurpriseRemoved) goto out; - } + up_clk(padapter, &x); - if (padapter->bSurpriseRemoved == true) { - RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true")); + if (padapter->bSurpriseRemoved) goto out; - } + down_clk(padapter, &x); out: _func_exit_; @@ -155,17 +146,14 @@ u16 eeprom_read16(_adapter *padapter, u16 reg) /*ReadEEprom*/ _func_enter_; - if (padapter->bSurpriseRemoved == true) { - RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true")); + if (padapter->bSurpriseRemoved) goto out; - } + /* select EEPROM, reset bits, set _EECS*/ x = rtw_read8(padapter, EE_9346CR); - if (padapter->bSurpriseRemoved == true) { - RT_TRACE(_module_rtl871x_eeprom_c_, _drv_err_, ("padapter->bSurpriseRemoved==true")); + if (padapter->bSurpriseRemoved) goto out; - } x &= ~(_EEDI | _EEDO | _EESK | _EEM0); x |= _EEM1 | _EECS; -- 2.20.1