Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?utf-8?Q?=C5=81ukasz_Stelmach?= <l.stelmach@samsung.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     linux-rtc@vger.kernel.org,
        =?utf-8?Q?Bart=C5=82omiej_=C5=BBolnierkiew?= =?utf-8?Q?icz?= 
        <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] rtc: rtc_update_irq_enable: rework UIE emulation
Date:   Fri, 02 Apr 2021 12:28:12 +0200
In-Reply-To: <20210330000343.801566-3-alexandre.belloni@bootlin.com>
        (Alexandre Belloni's message of "Tue, 30 Mar 2021 02:03:43 +0200")
Message-ID: <dleftjmtuhdlqb.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20210330000343.801566-3-alexandre.belloni@bootlin.com>
        <CGME20210402102813eucas1p1bae7ec57559fa8df622118275bf6fae0@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2021-03-30 wto 02:03>, when Alexandre Belloni wrote:
> Now that the core is aware of whether alarms are available, it is possible
> to decide whether UIE emulation is required before actually trying to set
> the alarm.
>
> This greatly simplifies rtc_update_irq_enable because there is now only o=
ne
> error value to track and is not relying on the return value of
> __rtc_set_alarm anymore.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
>  drivers/rtc/interface.c | 28 +++++++---------------------
>  1 file changed, 7 insertions(+), 21 deletions(-)
>

Tested-by: =C5=81ukasz Stelmach <l.stelmach@samsung.com>

> diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c
> index dcb34c73319e..b162964d2b39 100644
> --- a/drivers/rtc/interface.c
> +++ b/drivers/rtc/interface.c
> @@ -561,8 +561,12 @@ int rtc_update_irq_enable(struct rtc_device *rtc, un=
signed int enabled)
>  	if (rtc->uie_rtctimer.enabled =3D=3D enabled)
>  		goto out;
>=20=20
> -	if (rtc->uie_unsupported) {
> +	if (rtc->uie_unsupported || !test_bit(RTC_FEATURE_ALARM, rtc->features)=
) {
> +#ifdef CONFIG_RTC_INTF_DEV_UIE_EMUL
> +		err =3D rtc_dev_update_irq_enable_emul(rtc, enabled);
> +#else
>  		err =3D -EINVAL;
> +#endif
>  		goto out;
>  	}
>=20=20
> @@ -570,8 +574,8 @@ int rtc_update_irq_enable(struct rtc_device *rtc, uns=
igned int enabled)
>  		struct rtc_time tm;
>  		ktime_t now, onesec;
>=20=20
> -		rc =3D __rtc_read_time(rtc, &tm);
> -		if (rc)
> +		err =3D __rtc_read_time(rtc, &tm);
> +		if (err)
>  			goto out;
>  		onesec =3D ktime_set(1, 0);
>  		now =3D rtc_tm_to_ktime(tm);
> @@ -585,24 +589,6 @@ int rtc_update_irq_enable(struct rtc_device *rtc, un=
signed int enabled)
>  out:
>  	mutex_unlock(&rtc->ops_lock);
>=20=20
> -	/*
> -	 * __rtc_read_time() failed, this probably means that the RTC time has
> -	 * never been set or less probably there is a transient error on the
> -	 * bus. In any case, avoid enabling emulation has this will fail when
> -	 * reading the time too.
> -	 */
> -	if (rc)
> -		return rc;
> -
> -#ifdef CONFIG_RTC_INTF_DEV_UIE_EMUL
> -	/*
> -	 * Enable emulation if the driver returned -EINVAL to signal that it has
> -	 * been configured without interrupts or they are not available at the
> -	 * moment.
> -	 */
> -	if (err =3D=3D -EINVAL)
> -		err =3D rtc_dev_update_irq_enable_emul(rtc, enabled);
> -#endif
>  	return err;
>  }
>  EXPORT_SYMBOL_GPL(rtc_update_irq_enable);

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmBm8bwACgkQsK4enJil
gBD42wf/UcrU2D9DLxVyCc1wtFCR+nbGigi/3pfka0FGhspMGjPhXlmbthkob3Eo
hTPvfZCUjAZ1G6SV3ZgCrLqKzqiKmtYQLdfZKnH7i+p8t5Uc5CfbV/mhfupZbrS+
PphJCO+sW/yiz0eeDLptDPhUhr7modWBsDS4+WK4o9AwBOXMZfKoJErn9UutTNIV
EEevVHzXc00nlRt7MU5D6s8E1OIn8HXhEcBDJJ2DssqtOj2Xw7RncNfxUNyHg+Ke
QpdAxH31lYRHnvQEpLEkcbqY3JkJpsOjpI2ID1+V69iIVeEQymw18C/Sbf9BYlSW
Ns7y1JVtzTA/b//7RAOvJRDOD89pcQ==
=sLOG
-----END PGP SIGNATURE-----
--=-=-=--