Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1267061pxf; Fri, 2 Apr 2021 06:05:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwD0HrWxyEw51ZWUN/aE5BaAlFJkXLkUvxTv+GVrncjYcIk9/sWaP8rua3qrH+uPbWd3D1M X-Received: by 2002:aa7:cf17:: with SMTP id a23mr15851576edy.30.1617368705333; Fri, 02 Apr 2021 06:05:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617368705; cv=none; d=google.com; s=arc-20160816; b=giZ/SfbTOVdP0XMJP1VCMj2+wjkbcANCS74XsOP6AKAHsK1biT6aP7ETWq/EJ3HBRe V2Rg+6M0+PFA+gUS3maL+NMDmuyGU/yPMF5ccm2eqSAKM8mnnht7Zor9jbmsWODOxalJ v3xur9bgE4rn/+kGb7EbRNUd0Ei1oasTu4ljPQVEjkTH7PnAq7tx8LQrK6aClhNkSwYp cmSdV52XxBYVQxJkMmpGAW9TGeAzuUC4jz2/4FScQRj1rSjstRpKcSw50lgbhgo7mgnl 3Cpc7wcnk+Gowxq203fVapC6Fe1jsHHekatH08QibG9cegUvlC0DTThmd3CHeeaFaYc3 JJKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uTN7GP5Y8DqpShutxxOZR+o6yoQl//v/6cvvpP11nVQ=; b=uQXTI0Ol2V7faywfa5kKCxVMda6s+zSBazaL2UiqGFv5CI/qbHZ50A3wJMJ7gjWPEh LvMd4hMZLP3ReKNCzM5u8D0CJJw5Mzst3FPOJO/jP2cj+X2QEzVJ9Nr1lZQ+i9cYMOQD l2Nhrbu+GxwBsVn2qhF+2pygA4gIkEJeeO3j5z25lKB+8CkXj880GwwtSpWbkktIIZhg LzhXjcLPAq/xwVgu1QOCJyQbwFY40Nn3DfsIUiKSg4GaTnVL4rQmU1CeRB7k8v/yNqeK 7rWu+5uZmdqDSn6FjtmV8TWu8MsYuem2y80Bgr8+DVrGZS+dDPHkxUsPF4hYgqDxtivQ nrmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FuV6IrYg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e22si6897676edu.575.2021.04.02.06.04.42; Fri, 02 Apr 2021 06:05:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FuV6IrYg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235400AbhDBNEH (ORCPT + 99 others); Fri, 2 Apr 2021 09:04:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:57100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234628AbhDBNEG (ORCPT ); Fri, 2 Apr 2021 09:04:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F18FB61152; Fri, 2 Apr 2021 13:04:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617368645; bh=uTN7GP5Y8DqpShutxxOZR+o6yoQl//v/6cvvpP11nVQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FuV6IrYg5owX37hvdQ3GDhli6J7grV8XxceW0qLbZNTUg+/u8NZIwSSwacl3qPLQ3 zLUR9Zs1xeopBv9IW9LGAV8L74VKugKQWoIxBFpG4pqPxqye/g2CSnZJlxn0twTMnk DD/pKdTaCPk6nnvb7gGmON8Vqfo2zEq9DTdjktOI= Date: Fri, 2 Apr 2021 15:04:02 +0200 From: Greg Kroah-Hartman To: Ivan Safonov Cc: Larry Finger , Michael Straube , "Gustavo A. R. Silva" , Peilin Ye , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging:r8188eu: refactor OnAction(): use switch instead table lookup Message-ID: References: <20210328163323.53163-1-insafonov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210328163323.53163-1-insafonov@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 28, 2021 at 07:33:23PM +0300, Ivan Safonov wrote: > The switch is easier to read and refactor. Your subject line is incorrect :(