Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 2 Apr 2021 10:45:15 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Wan Jiabing <wanjiabing@vivo.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>, kael_w@yeah.net
Subject: Re: [PATCH] tools: perf: util: Remove duplicate struct declaration
Message-ID: <YGcf65apSLYuOhyi@kernel.org>
References: <20210401062424.991737-1-wanjiabing@vivo.com>
 <CAM9d7ciHzUDJc0KutAKoBqB2RA7pheB44=xv7dZ97=UqdNtv_g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAM9d7ciHzUDJc0KutAKoBqB2RA7pheB44=xv7dZ97=UqdNtv_g@mail.gmail.com>
Precedence: bulk

Em Thu, Apr 01, 2021 at 04:19:38PM +0900, Namhyung Kim escreveu:
> Hello,
> 
> On Thu, Apr 1, 2021 at 3:25 PM Wan Jiabing <wanjiabing@vivo.com> wrote:
> >
> > struct target is declared twice. One has been declared
> > at 21st line. Remove the duplicate.
> >
> > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>
> 
> I think we can move all the forward declarations to the top
> (and sort them) as well.

Thanks, applied.

- Arnaldo