Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 2 Apr 2021 16:25:56 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     He Ying <heying24@huawei.com>
Cc:     nsaenzjulienne@suse.de, sudeep.holla@arm.com,
        linus.walleij@linaro.org, robh@kernel.org, john.stultz@linaro.org,
        colin.king@canonical.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: qcom-scm: Fix QCOM_SCM configuration
Message-ID: <YGcpdDrDJiXQX2ZJ@kroah.com>
References: <20210331064941.134333-1-heying24@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210331064941.134333-1-heying24@huawei.com>
Precedence: bulk

On Wed, Mar 31, 2021 at 02:49:41AM -0400, He Ying wrote:
> When CONFIG_QCOM_SCM is y while CONFIG_HAVE_ARM_SMCCC
> is not set, compiling errors are encountered as follows:
> 
> drivers/firmware/qcom_scm-smc.o: In function `__scm_smc_do_quirk':
> qcom_scm-smc.c:(.text+0x36): undefined reference to `__arm_smccc_smc'
> drivers/firmware/qcom_scm-legacy.o: In function `scm_legacy_call':
> qcom_scm-legacy.c:(.text+0xe2): undefined reference to `__arm_smccc_smc'
> drivers/firmware/qcom_scm-legacy.o: In function `scm_legacy_call_atomic':
> qcom_scm-legacy.c:(.text+0x1f0): undefined reference to `__arm_smccc_smc'
> 
> So add dependency on HAVE_ARM_SMCCC in QCOM_SCM configuration.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: He Ying <heying24@huawei.com>
> ---
>  drivers/firmware/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

What commit caused this problem to show up?  Please add a "Fixes:" tag
in here and resend.

thanks,

greg k-h