Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1360101pxf; Fri, 2 Apr 2021 08:25:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNdFYyhyZAh0APPUTJcr7mdJKHdZOUaQLxiTTcjAAVTh6Cb1uYbh1XXyKWwMqQxxDWufpm X-Received: by 2002:a17:906:3385:: with SMTP id v5mr14600706eja.539.1617377116524; Fri, 02 Apr 2021 08:25:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617377116; cv=none; d=google.com; s=arc-20160816; b=CluUnVGoeLhXL+ChjvYA2uw8BvV889DuklhA28wMadVPvPUoVL0/BTQFXYG7Fx3ZZ4 TopaKesJypNy/XtBsxPYAWMIM6xIgYEqxIKsIVlJAl+2ohPmP7S7t8bbWGW772TgJ7q6 GpwJLeQncM/FjvTMXCeJplxB655zZ1UFE+YxHlOpjBatONy8/jnI+zRwMXDhTWxJQbOC v6sps4z2PGwEv8SF+5Zl4+GmuzumYFMuAr5z4ZWsk4a9XUEnd0/sLW2EBLBGh88wP4ih 4qqG8Qtt0DO/w17JUSWOC642XVOT5niwbkUvVdEBwhWX6E08cSm5Q/h7iulOfrRQomy+ Z8Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=+LqtCp7mdIo3A/iHxSztvz2tjNNUkd65D8/IuJdO7ak=; b=IXRrcok2z0rj4zIRcj3w7tyL372S8VAb3YFWd2aCRJiIrg47qz57m0XNs1tJoaYNYk THU6HbYbaZVGbhX6/He+1QhSU+smSFq1Ss3cA/sWV/DrJ/0TwULoySVMUgR40U0SfxlK 0rgkqvnvEbz0LmQsXj1wMqYhtMNrTJt5vCiVrMZYvH2BaxHnTqLd6E4I8kZJj3h/LW5F IRZmcIkgpNQzVKaVNfpjcoKJ9sgUZ16JtjMBeZry/35vjNYX7uJ++HWDrlLpeFFZfKUR h/wMNgPO5ZE1nYIxymBYgoblLjHGEMqvnN997LgqxszDHneqnkBKUHofJF/vWS/SNNo3 4d7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bx25si7089205edb.242.2021.04.02.08.24.53; Fri, 02 Apr 2021 08:25:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236530AbhDBPYS (ORCPT + 99 others); Fri, 2 Apr 2021 11:24:18 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:39144 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236265AbhDBPYI (ORCPT ); Fri, 2 Apr 2021 11:24:08 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4FBkNg3qflz9v2lr; Fri, 2 Apr 2021 17:24:03 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id p7d0djYUxLsL; Fri, 2 Apr 2021 17:24:03 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4FBkNg2q0Cz9v2lh; Fri, 2 Apr 2021 17:24:03 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 561DF8BB7C; Fri, 2 Apr 2021 17:24:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id Zgwotd5lGVEn; Fri, 2 Apr 2021 17:24:05 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 5C2EA8BB6F; Fri, 2 Apr 2021 17:24:04 +0200 (CEST) Subject: Re: [PATCH v3 05/17] arm: Convert to GENERIC_CMDLINE To: Rob Herring Cc: Will Deacon , Daniel Walker , Daniel Gimpelevich , "open list:GENERIC INCLUDE/ASM HEADER FILES" , devicetree@vger.kernel.org, linuxppc-dev , "linux-kernel@vger.kernel.org" , linux-arm-kernel , microblaze , "open list:MIPS" , nios2 , Openrisc , linux-hexagon@vger.kernel.org, linux-riscv , X86 ML , linux-xtensa@linux-xtensa.org, SH-Linux , sparclinux References: <7362e4f6a5f5b79e6ad3fd3cec3183a4a283f7fc.1616765870.git.christophe.leroy@csgroup.eu> From: Christophe Leroy Message-ID: <84ca838c-d77b-0142-7f45-b8b95c03d81e@csgroup.eu> Date: Fri, 2 Apr 2021 17:24:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 26/03/2021 à 16:47, Rob Herring a écrit : > On Fri, Mar 26, 2021 at 7:44 AM Christophe Leroy > wrote: >> >> This converts the architecture to GENERIC_CMDLINE. >> >> Signed-off-by: Christophe Leroy >> --- >> arch/arm/Kconfig | 38 +---------------------------------- >> arch/arm/kernel/atags_parse.c | 15 +++++--------- >> 2 files changed, 6 insertions(+), 47 deletions(-) >> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index 5da96f5df48f..67bc75f2da81 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -50,6 +50,7 @@ config ARM >> select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY >> select GENERIC_ATOMIC64 if CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI >> select GENERIC_CLOCKEVENTS_BROADCAST if SMP >> + select GENERIC_CMDLINE if ATAGS > > Don't we need this enabled for !ATAGS (i.e. DT boot)? > > Can we always enable GENERIC_CMDLINE for OF_EARLY_FLATTREE? > Yes missed it in v3 after your comment on v2. Done in v4.