Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210401075117.998330-1-wanjiabing@vivo.com>
In-Reply-To: <20210401075117.998330-1-wanjiabing@vivo.com>
From:   Steve French <smfrench@gmail.com>
Date:   Fri, 2 Apr 2021 10:42:09 -0500
Message-ID: <CAH2r5ms-rZPZi9TLE6f4Xoc33B51YKbuT+pVy8xaeNFzg9jLVg@mail.gmail.com>
Subject: Re: [PATCH] fs: cifs: Remove unnecessary struct declaration
To:     Wan Jiabing <wanjiabing@vivo.com>
Cc:     Steve French <sfrench@samba.org>,
        CIFS <linux-cifs@vger.kernel.org>,
        samba-technical <samba-technical@lists.samba.org>,
        LKML <linux-kernel@vger.kernel.org>, kael_w@yeah.net
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

merged into cifs-2.6.git for-next

On Thu, Apr 1, 2021 at 2:52 AM Wan Jiabing <wanjiabing@vivo.com> wrote:
>
> struct cifs_readdata is declared twice. One is declared
> at 208th line.
> And struct cifs_readdata is defined blew.
> The declaration here is not needed. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  fs/cifs/cifsglob.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index 67c056a9a519..ec824ab8c5ca 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -1283,8 +1283,6 @@ struct cifs_aio_ctx {
>         bool                    direct_io;
>  };
>
> -struct cifs_readdata;
> -
>  /* asynchronous read support */
>  struct cifs_readdata {
>         struct kref                     refcount;
> --
> 2.25.1
>


-- 
Thanks,

Steve