Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1382860pxf; Fri, 2 Apr 2021 09:03:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQAyLBQR6bz3Fn4IcYizOg6BnI6KF3CasL66hIFDYy50nkZ/G+xpzYdkUd6Om7gc5LxdXG X-Received: by 2002:a17:907:7683:: with SMTP id jv3mr1273847ejc.450.1617379385489; Fri, 02 Apr 2021 09:03:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617379385; cv=none; d=google.com; s=arc-20160816; b=0BdlRvqtHLrEU6wgPRrujgBT9XwOzs8ELPonGZ8e06FGqJVbIYJ4VdK0lKJC8dfEy7 WuPyu21b9XP3SrmCWV6RZofzlF8T9HUD/+aiy2EHG3Kq8Cm11Ua+GsYSIcCjlhfc9s2W qk6GhnoDFsAtHqX6Sk7kMe8KgMqvrgnnwpgGCFtV37E9J3Jcb0CIXh1/oLr9p8/M2RC4 jr3LIJ6UycXWKYn9KS1kuvIZsP/N2jTNNQ7blOtDTAcDhCfDoHoX1XeEGR2nAzzDput5 NSPr+OXHC4wwDcpXmCVmhaddVdFEZDktLWFULPFAgWQ0B42IUHPbGC5S+i+jvjl0oohV wBag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:sender :dkim-signature; bh=43FpCxX0SVzfOugEOQk73VHo0lcUDXRR1mTG2VJrV24=; b=0Ug+Mt7P6TXMpGkiCeKAnmcI/pR7TWrrFqIZGywV/BQTYl49fbINkZE81aLSDyYOk6 0H+jz9b4EJqqW+tO+prCnwZaP0/nOEuwIE7EZBZy4LnpRxW9Igg3zn9368qfq7ivyDFi h4iLP5DFrlOkGP8gGbBp+/I4e2Yzxam4E5QYWYhoiRyZl3FwxxuP+6CP0Ga8wyKshRDG +W7Y4i2EDdffjDV4lJdYy+HNiLEUzJ/7lN5gyXXZnM6yyVPLzP6X0PDby5Qv87h4ZOUO lBUpya3trtQHxuMWribO+dzr/PPvm72Ba4AQGl07HkmXXjkU61tbleN2YkImkPZKK8Q2 gxGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=O71U8Ikg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hr7si7528383ejc.596.2021.04.02.09.02.40; Fri, 02 Apr 2021 09:03:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=O71U8Ikg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236515AbhDBP6f (ORCPT + 99 others); Fri, 2 Apr 2021 11:58:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236339AbhDBP6P (ORCPT ); Fri, 2 Apr 2021 11:58:15 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A91AC0613E6; Fri, 2 Apr 2021 08:58:14 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id b9so5098510wrt.8; Fri, 02 Apr 2021 08:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=43FpCxX0SVzfOugEOQk73VHo0lcUDXRR1mTG2VJrV24=; b=O71U8IkgAOkcDTf0HexDGvvYgfmnzBNBLucYyXbL6gsSmc0cC6b+ibn0v+g83j0Sq+ 0o2Ds99FytvE/8nT4kZrDGQkHOwd7HfvVbi+vy77EBZvVwFDEIQq7gDhzdSMQmtI8WEJ WsTlunnqyNvUZ2dE8XIH4sbIC/jLB98ohUvPVfLztONbgMvOsWDfLKmhPkIR4Ag32vU8 wPYBJHgaQkHo/TNTxN1jaggCnHiOOAvS0PryD2YaMCTZ9yGQ3DPjF+swLv2QAbxXXylt 7TqqVYg9hTyT5/scedmBrdYTdAZEW/UHXIkLvlMpWQpnwu/geL47ZHFxsOnrBtXWuKkF cErw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=43FpCxX0SVzfOugEOQk73VHo0lcUDXRR1mTG2VJrV24=; b=qnTL/pps5rwin9Gmkfw5vdnvUAClymtOh1crxFZJ+nxMKqQBflfKj879thI2/SVDtu /hEvBFTjSx7aNYA6ZOTEJeTOxy5OoNLLBTiCOmaX2ocPVFjz40IIsqKK1CglKhcLQGwz Bx0yi4vH85b7lEKIvuVEpfAmEbi9ijn0ov/FYtA1+/nWBtIMTyzPxe//2UsSo8naZmZM l/lR62Wom8d4dD7XVmnHn2kYTbekdFhBZEzpjijs0mCyn1eZm5SbUplHsf896Io09Zt0 SGaafyfAJhRGEec8HpUHL6ApzI77LG9eWGV+edKvV+GcV5pdZ9ZkGjGyaenQIjRrnMAP 5p/g== X-Gm-Message-State: AOAM531gVLfjdsGh1g7kJxEffQ6IQl5Dn0ojLcX9ccreWVTdA0rsr7BE 4N/OFkP79vd5jLmjAyiysyZHwt1Ppn4= X-Received: by 2002:a5d:42ca:: with SMTP id t10mr15796822wrr.274.1617379092877; Fri, 02 Apr 2021 08:58:12 -0700 (PDT) Received: from avogadro.lan ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id w11sm2293625wmb.35.2021.04.02.08.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 08:58:12 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: chenhuacai@kernel.org, aleksandar.qemu.devel@gmail.com, seanjc@google.com, linux-mips@vger.kernel.org Subject: [PATCH 4/4] KVM: MIPS: defer flush to generic MMU notifier code Date: Fri, 2 Apr 2021 17:58:07 +0200 Message-Id: <20210402155807.49976-5-pbonzini@redhat.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210402155807.49976-1-pbonzini@redhat.com> References: <20210402155807.49976-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return 1 from kvm_unmap_hva_range and kvm_set_spte_hva if a flush is needed, so that the generic code can coalesce the flushes. Signed-off-by: Paolo Bonzini --- arch/mips/kvm/mmu.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/arch/mips/kvm/mmu.c b/arch/mips/kvm/mmu.c index 2cedf908d744..a3a49b009dc4 100644 --- a/arch/mips/kvm/mmu.c +++ b/arch/mips/kvm/mmu.c @@ -489,9 +489,7 @@ static int kvm_unmap_hva_handler(struct kvm *kvm, gfn_t gfn, gfn_t gfn_end, int kvm_unmap_hva_range(struct kvm *kvm, unsigned long start, unsigned long end, unsigned flags) { - handle_hva_to_gpa(kvm, start, end, &kvm_unmap_hva_handler, NULL); - kvm_flush_remote_tlbs(kvm); - return 0; + return handle_hva_to_gpa(kvm, start, end, &kvm_unmap_hva_handler, NULL); } static int kvm_set_spte_handler(struct kvm *kvm, gfn_t gfn, gfn_t gfn_end, @@ -528,12 +526,7 @@ static int kvm_set_spte_handler(struct kvm *kvm, gfn_t gfn, gfn_t gfn_end, int kvm_set_spte_hva(struct kvm *kvm, unsigned long hva, pte_t pte) { unsigned long end = hva + PAGE_SIZE; - int ret; - - ret = handle_hva_to_gpa(kvm, hva, end, &kvm_set_spte_handler, &pte); - if (ret) - kvm_flush_remote_tlbs(kvm); - return 0; + return handle_hva_to_gpa(kvm, hva, end, &kvm_set_spte_handler, &pte); } static int kvm_age_hva_handler(struct kvm *kvm, gfn_t gfn, gfn_t gfn_end, -- 2.30.1