Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] kunit: tool: make --kunitconfig accept dirs, add
 lib/kunit fragment
To:     Brendan Higgins <brendanhiggins@google.com>, dlatypov@google.com
Cc:     davidgow@google.com, kunit-dev@googlegroups.com,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        tytso@mit.edu, Shuah Khan <skhan@linuxfoundation.org>
References: <20210222225241.201145-1-dlatypov@google.com>
 <20210402093228.755260-1-brendanhiggins@google.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <38510e93-843c-b0e0-5ad5-4953660de79b@linuxfoundation.org>
Date:   Fri, 2 Apr 2021 12:00:01 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210402093228.755260-1-brendanhiggins@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/2/21 3:32 AM, Brendan Higgins wrote:
>> TL;DR
>> $ ./tools/testing/kunit/kunit.py run --kunitconfig=lib/kunit
>>
>> Per suggestion from Ted [1], we can reduce the amount of typing by
>> assuming a convention that these files are named '.kunitconfig'.
>>
>> In the case of [1], we now have
>> $ ./tools/testing/kunit/kunit.py run --kunitconfig=fs/ext4
>>
>> Also add in such a fragment for kunit itself so we can give that as an
>> example more close to home (and thus less likely to be accidentally
>> broken).
>>
>> [1] https://lore.kernel.org/linux-ext4/YCNF4yP1dB97zzwD@mit.edu/
>>
>> Signed-off-by: Daniel Latypov <dlatypov@google.com>
> 
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> 

Should this be captured in  documentation. Especially since this
is file is .* file.

Do you want to include doc in this patch? Might be better that way.

thanks,
-- Shuah