Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1472326pxf; Fri, 2 Apr 2021 11:23:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAjn37ZZvK4MQu/CUTEZmzeQPYTiiEBAhoa3Ovmn5n9rSqfIw47FYr13jMdeP32wIAz4+t X-Received: by 2002:a17:906:b4c:: with SMTP id v12mr15375293ejg.330.1617387787479; Fri, 02 Apr 2021 11:23:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617387787; cv=none; d=google.com; s=arc-20160816; b=zAzorACAMpe/45qoldPfIQIshnHbOu+whqzr9EJlnZhoXMnBz5C3w7VCrQk6dA0Ntp 4An9KBtyEjSa4RxgaMbnFisHvBQQIJBEB1OvTEDqc0R8yOUhLv4qXhlAKIj7vfgC75EF S39DUaJxS7Ouo1iYSB43WB0dsQWXloChK6o1aNMO9FOInQ2ITbkCIqb3/288il3HO+oo kn209N9/iW43GFYUKL16nsMeLTcjL0GQCR2PJ03XBhDfUyQzI+BUtCli2ribPG3jB1QC PL0ne6oRWcmT6R6FPb3ww05HhmoDyJ3mm1InhZoDjYBRnW4B7tH0PX9Rorz/MfIPqVhe 7q/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=IK3P6moRtbr3GXePGjyoKwVTBySnTC80FZZAwgYpc2k=; b=qDUOU1N42cjUXxotKajxkqCGulHx7zdza8NRw/jSym2LdkqL5ijB3mkNAFp4me4THj WHlgkku3PgV7sjT7REbNWAgw/+s+b4jwqEFUkGZNMVxjCzQ0dQfH31YrB+Kzt+3S8ekN mIJ0y3wL7/MP1NN9S5n+v5b9BMwPG/kLCS39/me0EoOu5o8Ab+kVp64L93viffpN1JNv dX56Ez/qTEPTumwuz+genky2e14MZ93tNlxEsGeyy92sFRxCQCEXZHtePalb3MWIAYrU E6fZZ2eXfcLVOhOimpfNFn1SBHiEwsmI8xnFe8Af53oX8LuLuWUUXFWpy4rVO2grAx64 Oryw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OANzGNsA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gs18si7063900ejb.648.2021.04.02.11.22.45; Fri, 02 Apr 2021 11:23:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OANzGNsA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236403AbhDBSVA (ORCPT + 99 others); Fri, 2 Apr 2021 14:21:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236364AbhDBSUz (ORCPT ); Fri, 2 Apr 2021 14:20:55 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30CCAC0613E6; Fri, 2 Apr 2021 11:20:54 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id j4-20020a05600c4104b029010c62bc1e20so2726582wmi.3; Fri, 02 Apr 2021 11:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IK3P6moRtbr3GXePGjyoKwVTBySnTC80FZZAwgYpc2k=; b=OANzGNsAYXnblsIsVSpq9y6XcOiByCDvuKNym1v+nCzx7++T/1z6pzz6DB3PV2Ih6w 8redi8QHQ85zWSba0oNwsBOPl5EXGTbavpgebV7Ol/cpKh8Ed7yvcZV8mfr6JSXlJGWr QyqwNmIbGvTYV50rIWkaHWmShBeJ7poejZlU98UTOeJnh8E0tGbDr+NtzHJ0VL2mKKKk j+yfhdeKnDIhdiJ57E+DKGyC8T4jIBTY3no8Lol+2wOPYHaq1xswGqJodZkW4dXUZJyt nTmDsxFqiT1eG5fozBiKOsPsQEdnvkauNNIvJvq+MgrrQpV3icylnF+RJ1Q96nXptHJb tbnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IK3P6moRtbr3GXePGjyoKwVTBySnTC80FZZAwgYpc2k=; b=LU3JowwARYVpEOjERI8uVRjlW6I1yxAcw4z0Pi5GAGKYDenXl7UvvFeOScKULdFj4L h3hnEDOVBeGJ6lhu9zW0z7sNFxzuNmS6ZgabAz/4W3q4PfotMNx8IBHyFnu1AaZtww0L h4sGGXJ4hrYFr7Itv45dB6TqTavaq0ABVS+xKWDZ3aB6PK/Su52m8e2+Z65OdkAk5KvD agHGxphj0uf9Vhx3gKlTV7O2P9bnkVMlQXugeYgAq/4xs05IndY8HftbDJT916zJwzWm +Kg6KqVmOW/zzQ6YlwfQfOm+v+skDNTJnZp0AGMn4J1lsgVKkI/KIQPyGDWnQ7l5exQW 61Og== X-Gm-Message-State: AOAM532fZRTW1l77mqrFYrcXjYwfNa5mTwQ12zR8EfaOL92gZW1Mczv3 ZYahZk27CgdpLHKwLwstzI0rXlqjOdY= X-Received: by 2002:a7b:c357:: with SMTP id l23mr13677428wmj.152.1617387652748; Fri, 02 Apr 2021 11:20:52 -0700 (PDT) Received: from [192.168.1.101] ([37.166.24.151]) by smtp.gmail.com with ESMTPSA id h10sm15189196wrp.22.2021.04.02.11.20.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Apr 2021 11:20:52 -0700 (PDT) Subject: Re: [PATCH net v2] atl1c: move tx cleanup processing out of interrupt To: Gatis Peisenieks , chris.snook@gmail.com, davem@davemloft.net, kuba@kernel.org, hkallweit1@gmail.com, jesse.brandeburg@intel.com, dchickles@marvell.com, tully@mikrotik.com, eric.dumazet@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Eric Dumazet Message-ID: <502d7e87-3bd9-29f3-eb18-753331d424e6@gmail.com> Date: Fri, 2 Apr 2021 20:20:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/2/21 7:20 PM, Gatis Peisenieks wrote: > Tx queue cleanup happens in interrupt handler on same core as rx queue processing. > Both can take considerable amount of processing in high packet-per-second scenarios. > ... > @@ -2504,6 +2537,7 @@ static int atl1c_init_netdev(struct net_device *netdev, struct pci_dev *pdev) >                  NETIF_F_TSO6; >      netdev->features =    netdev->hw_features    | >                  NETIF_F_HW_VLAN_CTAG_TX; > +    netdev->threaded = true; Shouldn't it use dev_set_threaded() ? >      return 0; >  } > > @@ -2588,6 +2622,7 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent) >      adapter->mii.phy_id_mask = 0x1f; >      adapter->mii.reg_num_mask = MDIO_CTRL_REG_MASK; >      netif_napi_add(netdev, &adapter->napi, atl1c_clean, 64); > +    netif_napi_add(netdev, &adapter->tx_napi, atl1c_clean_tx, 64); >      timer_setup(&adapter->phy_config_timer, atl1c_phy_config, 0); >      /* setup the private structure */ >      err = atl1c_sw_init(adapter);