Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1610158662-3926-1-git-send-email-jrdr.linux@gmail.com>
In-Reply-To: <1610158662-3926-1-git-send-email-jrdr.linux@gmail.com>
From:   Souptick Joarder <jrdr.linux@gmail.com>
Date:   Sat, 3 Apr 2021 01:38:41 +0530
Message-ID: <CAFqt6zb405L9AhrzdMd3CTRCFN9J9kEVE5vudeF_R4OfVjLygQ@mail.gmail.com>
Subject: Re: [PATCH] perf/core: Mark perf_pmu_snapshot_aux() as static
To:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, acme@kernel.org,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        jolsa@redhat.com, namhyung@kernel.org
Cc:     linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Jan 9, 2021 at 7:47 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> Kernel test robot throws below warning ->
>
>  kernel/events/core.c:6535:6: warning: no previous prototype for
> 'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
>     6535 | long perf_pmu_snapshot_aux(struct perf_buffer *rb,
>          |      ^~~~~~~~~~~~~~~~~~~~~
> Marking perf_pmu_snapshot_aux() as static as it is not used outside
> this file.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

Any comment on this patch ?

> ---
>  kernel/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 55d1879..a4ba6fd 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -6532,7 +6532,7 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event,
>         return data->aux_size;
>  }
>
> -long perf_pmu_snapshot_aux(struct perf_buffer *rb,
> +static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
>                            struct perf_event *event,
>                            struct perf_output_handle *handle,
>                            unsigned long size)
> --
> 1.9.1
>